From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Perale via buildroot <buildroot@buildroot.org>
Cc: Romain Naour <romain.naour@gmail.com>,
Thomas Perale <thomas.perale@mind.be>
Subject: Re: [Buildroot] [PATCH 1/1] package/aubio: fix build on big endian arch
Date: Wed, 2 Oct 2024 23:38:45 +0200 [thread overview]
Message-ID: <20241002233845.709e0e6d@windsurf> (raw)
In-Reply-To: <20240922150554.1348962-1-thomas.perale@mind.be>
On Sun, 22 Sep 2024 17:05:54 +0200
Thomas Perale via buildroot <buildroot@buildroot.org> wrote:
> Fixes the following error happening on builds with
> big endian architecture target and libflac enabled.
>
> ```
> [ 75/243] Linking build/tests/test-pitchshift
> /home/autobuild/autobuild/instance-16/output-1/per-package/aubio/host/bin/../lib/gcc/mips64-buildroot-linux-gnu/13.3.0/../../../../mips64-buildroot-linux-gnu/bin/ld: src/libaubio.so: undefined reference to `SWAPS'
> collect2: error: ld returned 1 exit status
>
> Waf: Leaving directory `/home/autobuild/autobuild/instance-16/output-1/build/aubio-152d6819b360c2e7b379ee3f373d444ab3df0895/build'
> Build failed
> ```
>
> There is a missing definition of the `SWAPS` macro in
> `/src/io/sink_flac.c` file.
> This patch adds an out of tree patch that copy the `SWAPS` definition from the
> `/src/io/sink_wavwrite.c` file in `sink_flac.c` to fix this issue.
>
> Fixes:
> - https://autobuild.buildroot.org/results/b88/b8895a81411dc7622b0aba9f2f0eaa0aef5a1a10/
> - https://autobuild.buildroot.org/results/bc7/bc733f5192b354cb960b6a4726efb597be4bb06c/
> - https://autobuild.buildroot.org/results/ea5/ea52dbcc14c2bab300277053f0b9599a8e82294a/
> - ...
>
> Signed-off-by: Thomas Perale <thomas.perale@mind.be>
> ---
> ...1-sink_flac-missing-SWAPS-definition.patch | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 package/aubio/0001-sink_flac-missing-SWAPS-definition.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-10-02 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 15:05 [Buildroot] [PATCH 1/1] package/aubio: fix build on big endian arch Thomas Perale via buildroot
2024-10-02 21:38 ` Thomas Petazzoni via buildroot [this message]
2024-10-19 19:55 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002233845.709e0e6d@windsurf \
--to=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
--cc=thomas.perale@mind.be \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.