All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: tools <tools@linux.kernel.org>
Subject: Re: b4 trailers --update picks up bogus trailers
Date: Thu, 3 Oct 2024 11:13:03 -0400	[thread overview]
Message-ID: <20241003-exuberant-eccentric-mouse-7f5aaa@lemur> (raw)
In-Reply-To: <98450a13-1339-41e1-87b4-3db7387906c7@sirena.org.uk>

On Wed, Oct 02, 2024 at 12:51:50PM GMT, Mark Brown wrote:
> With current git b4 if I run b4 trailers --update on
> 
>    https://lore.kernel.org/linux-arm-kernel/20241001-arm64-gcs-v13-0-222b78d87eee@kernel.org/T/#t
> 
> patch 2 picks up reviewed-by trailers which were sent in reply to the
> prior versions of the series even though that patch is new in this
> version so the update is clearly bogus.

Okay, this was a bit hairier than I was expecting, but we now do a proper
patch-id match for all trailers we have received and only apply them to the
patches that have not changed between what the reviewer tagged and what is in
the current tree.

Please try it out in the latest master.

-K

  parent reply	other threads:[~2024-10-03 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-02 11:51 b4 trailers --update picks up bogus trailers Mark Brown
2024-10-02 13:34 ` Konstantin Ryabitsev
2024-10-02 13:52   ` Mark Brown
2024-10-02 14:14     ` Konstantin Ryabitsev
2024-10-02 14:20 ` Bugspray Bot
2024-10-03 15:13 ` Konstantin Ryabitsev [this message]
2024-10-03 15:36   ` Mark Brown
2024-10-03 15:15 ` Bugspray Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241003-exuberant-eccentric-mouse-7f5aaa@lemur \
    --to=konstantin@linuxfoundation.org \
    --cc=broonie@kernel.org \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.