From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Kozyrev <akozyrev@nvidia.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>, <rasland@nvidia.com>,
<viacheslavo@nvidia.com>, <matan@nvidia.com>
Subject: Re: [PATCH] drivers: fix error CQE handling
Date: Thu, 3 Oct 2024 12:14:57 -0700 [thread overview]
Message-ID: <20241003121457.37537b40@hermes.local> (raw)
In-Reply-To: <20230502184922.3249201-1-akozyrev@nvidia.com>
On Tue, 2 May 2023 21:49:22 +0300
Alexander Kozyrev <akozyrev@nvidia.com> wrote:
> The completion queue element size can be independently configured
> to report either 64 or 128 bytes CQEs by programming cqe_sz parameter
> at CQ creation. This parameter depends on the cache line size and
> affects both regular CQEs and error CQEs. But the error handling
> assumes that an error CQE is 64 bytes and doesn't take the padding
> into consideration on platforms with 128-byte cache lines.
> Fix the error CQE size in all error handling routines in mlx5.
>
> Fixes: 957e45fb7b ("net/mlx5: handle Tx completion with error")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
I have no idea about internals of mlx5 but the concept seems fine.
Patch needs to be rebased.
Please title it with net/mlx5 not drivers.
next prev parent reply other threads:[~2024-10-03 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 18:49 [PATCH] drivers: fix error CQE handling Alexander Kozyrev
2024-10-03 19:14 ` Stephen Hemminger [this message]
2024-10-03 20:26 ` [PATCH v2] " Alexander Kozyrev
2024-10-28 15:58 ` Slava Ovsiienko
2024-10-28 17:17 ` [PATCH v3] drivers: fix error CQE handling for 128 bytes CQE Alexander Kozyrev
2024-11-13 13:34 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003121457.37537b40@hermes.local \
--to=stephen@networkplumber.org \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.