All of lore.kernel.org
 help / color / mirror / Atom feed
From: cel@kernel.org
To: Neil Brown <neilb@suse.de>, Jeff Layton <jlayton@kernel.org>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH 04/16] xdrgen: XDR widths for enum types
Date: Thu,  3 Oct 2024 11:01:46 -0400	[thread overview]
Message-ID: <20241003150151.81951-5-cel@kernel.org> (raw)
In-Reply-To: <20241003150151.81951-1-cel@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

RFC 4506 says that an XDR enum is represented as a signed integer
on the wire; thus its width is 1 XDR_UNIT.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 tools/net/sunrpc/xdrgen/xdr_ast.py | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tools/net/sunrpc/xdrgen/xdr_ast.py b/tools/net/sunrpc/xdrgen/xdr_ast.py
index f1d93a1d0ed8..fbee954c7f70 100644
--- a/tools/net/sunrpc/xdrgen/xdr_ast.py
+++ b/tools/net/sunrpc/xdrgen/xdr_ast.py
@@ -227,6 +227,18 @@ class _XdrEnum(_XdrAst):
     maximum: int
     enumerators: List[_XdrEnumerator]
 
+    def max_width(self) -> int:
+        """Return width of type in XDR_UNITS"""
+        return 1
+
+    def symbolic_width(self) -> List:
+        """Return list containing XDR width of type's components"""
+        return ["XDR_int"]
+
+    def __post_init__(self):
+        max_widths[self.name] = self.max_width()
+        symbolic_widths[self.name] = self.symbolic_width()
+
 
 @dataclass
 class _XdrStruct(_XdrAst):
-- 
2.46.2


  parent reply	other threads:[~2024-10-03 15:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-03 15:01 [PATCH 00/16] xdrgen: Emit maxsize macros cel
2024-10-03 15:01 ` [PATCH 01/16] xdrgen: Refactor transformer arms cel
2024-10-03 15:01 ` [PATCH 02/16] xdrgen: Track constant values cel
2024-10-03 15:01 ` [PATCH 03/16] xdrgen: Keep track of on-the-wire data type widths cel
2024-10-03 15:01 ` cel [this message]
2024-10-03 15:01 ` [PATCH 05/16] xdrgen: XDR width for fixed-length opaque cel
2024-10-03 15:01 ` [PATCH 06/16] xdrgen: XDR width for variable-length opaque cel
2024-10-03 15:01 ` [PATCH 07/16] xdrgen: XDR width for a string cel
2024-10-03 15:01 ` [PATCH 08/16] xdrgen: XDR width for fixed-length array cel
2024-10-03 15:01 ` [PATCH 09/16] xdrgen: XDR width for variable-length array cel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241003150151.81951-5-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=dai.ngo@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.