From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: Re: [PATCH v5 2/2] eal: initialize shared plugins on Windows
Date: Thu, 3 Oct 2024 15:44:31 -0700 [thread overview]
Message-ID: <20241003154431.69f13d7e@hermes.local> (raw)
In-Reply-To: <3248363.l52yBJDM9G@thomas>
On Thu, 30 May 2024 10:02:46 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:
> > are you asking for the unix and windows implementations to be moved out
> > to eal/{windows,unix} respectively rather than the current conditional
> > compiled in eal/common?
>
> Yes I feel it would be better.
> Please tell me if I missed something.
>
> > > Also, the CI is failing with this patchset.
> > >
> >
> > i'll take a look when i get a chance, you can leave it unmerged for now.
Marking it as changes requested.
Would be good to split as requested.
next prev parent reply other threads:[~2024-10-03 22:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 19:20 [PATCH] eal: initialize shared plugins on Windows Tyler Retzlaff
2023-12-07 19:20 ` Tyler Retzlaff
2023-12-07 19:43 ` Tyler Retzlaff
2023-12-07 20:26 ` [PATCH v2] " Tyler Retzlaff
2023-12-07 20:26 ` Tyler Retzlaff
2024-01-03 0:05 ` [PATCH v3] " Tyler Retzlaff
2024-01-03 0:05 ` Tyler Retzlaff
2024-01-08 23:38 ` [PATCH v4 0/2] " Tyler Retzlaff
2024-01-08 23:38 ` [PATCH v4 1/2] windows: include winapifamily header for macros Tyler Retzlaff
2024-01-25 21:58 ` Dmitry Kozlyuk
2024-01-08 23:38 ` [PATCH v4 2/2] eal: initialize shared plugins on Windows Tyler Retzlaff
2024-01-25 23:04 ` Dmitry Kozlyuk
2024-01-25 18:44 ` [PATCH v4 0/2] " Tyler Retzlaff
2024-03-12 16:52 ` [PATCH v5 " Tyler Retzlaff
2024-03-12 16:52 ` [PATCH v5 1/2] eal/windows: make dirent.h shim compatible with MinGW Tyler Retzlaff
2024-03-12 16:52 ` [PATCH v5 2/2] eal: initialize shared plugins on Windows Tyler Retzlaff
2024-05-29 14:29 ` Thomas Monjalon
2024-05-29 17:56 ` Tyler Retzlaff
2024-05-30 8:02 ` Thomas Monjalon
2024-10-03 22:44 ` Stephen Hemminger [this message]
2024-03-28 18:18 ` [PATCH v5 0/2] " Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003154431.69f13d7e@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.