From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 1/5] crypto: cesa: add COMPILE_TEST
Date: Thu, 3 Oct 2024 17:20:10 +0800 [thread overview]
Message-ID: <202410031728.sQCYdNwD-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20241001232547.355947-2-rosenp@gmail.com>
References: <20241001232547.355947-2-rosenp@gmail.com>
TO: Rosen Penev <rosenp@gmail.com>
TO: linux-crypto@vger.kernel.org
CC: Boris Brezillon <bbrezillon@kernel.org>
CC: Arnaud Ebalard <arno@natisbad.org>
CC: Srujana Challa <schalla@marvell.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: Rosen Penev <rosenp@gmail.com>
CC: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
CC: linux-kernel@vger.kernel.org
Hi Rosen,
kernel test robot noticed the following build warnings:
[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master v6.12-rc1 next-20241003]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/crypto-cesa-add-COMPILE_TEST/20241002-072835
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link: https://lore.kernel.org/r/20241001232547.355947-2-rosenp%40gmail.com
patch subject: [PATCH 1/5] crypto: cesa: add COMPILE_TEST
:::::: branch date: 34 hours ago
:::::: commit date: 34 hours ago
config: um-randconfig-r073-20241003 (https://download.01.org/0day-ci/archive/20241003/202410031728.sQCYdNwD-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202410031728.sQCYdNwD-lkp@intel.com/
smatch warnings:
drivers/crypto/marvell/cesa/cipher.c:342 mv_cesa_skcipher_dma_req_init() warn: missing unwind goto?
vim +342 drivers/crypto/marvell/cesa/cipher.c
4ada4839782370 drivers/crypto/marvell/cipher.c Arnaud Ebalard 2015-06-18 311
e6cd5bf64855cc drivers/crypto/marvell/cipher.c Boris Brezillon 2017-10-13 312 static int mv_cesa_skcipher_dma_req_init(struct skcipher_request *req,
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 313 const struct mv_cesa_op_ctx *op_templ)
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 314 {
e6cd5bf64855cc drivers/crypto/marvell/cipher.c Boris Brezillon 2017-10-13 315 struct mv_cesa_skcipher_req *creq = skcipher_request_ctx(req);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 316 gfp_t flags = (req->base.flags & CRYPTO_TFM_REQ_MAY_SLEEP) ?
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 317 GFP_KERNEL : GFP_ATOMIC;
53da740fed302f drivers/crypto/marvell/cipher.c Romain Perier 2016-06-21 318 struct mv_cesa_req *basereq = &creq->base;
e6cd5bf64855cc drivers/crypto/marvell/cipher.c Boris Brezillon 2017-10-13 319 struct mv_cesa_skcipher_dma_iter iter;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 320 bool skip_ctx = false;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 321 int ret;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 322
53da740fed302f drivers/crypto/marvell/cipher.c Romain Perier 2016-06-21 323 basereq->chain.first = NULL;
53da740fed302f drivers/crypto/marvell/cipher.c Romain Perier 2016-06-21 324 basereq->chain.last = NULL;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 325
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 326 if (req->src != req->dst) {
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 327 ret = dma_map_sg(cesa_dev->dev, req->src, creq->src_nents,
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 328 DMA_TO_DEVICE);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 329 if (!ret)
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 330 return -ENOMEM;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 331
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 332 ret = dma_map_sg(cesa_dev->dev, req->dst, creq->dst_nents,
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 333 DMA_FROM_DEVICE);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 334 if (!ret) {
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 335 ret = -ENOMEM;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 336 goto err_unmap_src;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 337 }
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 338 } else {
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 339 ret = dma_map_sg(cesa_dev->dev, req->src, creq->src_nents,
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 340 DMA_BIDIRECTIONAL);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 341 if (!ret)
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 @342 return -ENOMEM;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 343 }
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 344
ec38f82e85532b drivers/crypto/marvell/cipher.c Romain Perier 2016-07-22 345 mv_cesa_tdma_desc_iter_init(&basereq->chain);
e6cd5bf64855cc drivers/crypto/marvell/cipher.c Boris Brezillon 2017-10-13 346 mv_cesa_skcipher_req_iter_init(&iter, req);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 347
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 348 do {
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 349 struct mv_cesa_op_ctx *op;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 350
655ff1a1a727f9 drivers/crypto/marvell/cesa/cipher.c SrujanaChalla 2020-03-13 351 op = mv_cesa_dma_add_op(&basereq->chain, op_templ, skip_ctx,
655ff1a1a727f9 drivers/crypto/marvell/cesa/cipher.c SrujanaChalla 2020-03-13 352 flags);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 353 if (IS_ERR(op)) {
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 354 ret = PTR_ERR(op);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 355 goto err_free_tdma;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 356 }
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 357 skip_ctx = true;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 358
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 359 mv_cesa_set_crypt_op_len(op, iter.base.op_len);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 360
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 361 /* Add input transfers */
ec38f82e85532b drivers/crypto/marvell/cipher.c Romain Perier 2016-07-22 362 ret = mv_cesa_dma_add_op_transfers(&basereq->chain, &iter.base,
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 363 &iter.src, flags);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 364 if (ret)
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 365 goto err_free_tdma;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 366
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 367 /* Add dummy desc to launch the crypto operation */
ec38f82e85532b drivers/crypto/marvell/cipher.c Romain Perier 2016-07-22 368 ret = mv_cesa_dma_add_dummy_launch(&basereq->chain, flags);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 369 if (ret)
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 370 goto err_free_tdma;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 371
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 372 /* Add output transfers */
ec38f82e85532b drivers/crypto/marvell/cipher.c Romain Perier 2016-07-22 373 ret = mv_cesa_dma_add_op_transfers(&basereq->chain, &iter.base,
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 374 &iter.dst, flags);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 375 if (ret)
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 376 goto err_free_tdma;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 377
e6cd5bf64855cc drivers/crypto/marvell/cipher.c Boris Brezillon 2017-10-13 378 } while (mv_cesa_skcipher_req_iter_next_op(&iter));
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 379
bac8e805a30dc2 drivers/crypto/marvell/cipher.c Romain Perier 2016-06-21 380 /* Add output data for IV */
655ff1a1a727f9 drivers/crypto/marvell/cesa/cipher.c SrujanaChalla 2020-03-13 381 ret = mv_cesa_dma_add_result_op(&basereq->chain,
655ff1a1a727f9 drivers/crypto/marvell/cesa/cipher.c SrujanaChalla 2020-03-13 382 CESA_SA_CFG_SRAM_OFFSET,
0c99620f0ac13a drivers/crypto/marvell/cipher.c Romain Perier 2016-10-05 383 CESA_SA_DATA_SRAM_OFFSET,
0c99620f0ac13a drivers/crypto/marvell/cipher.c Romain Perier 2016-10-05 384 CESA_TDMA_SRC_IN_SRAM, flags);
bac8e805a30dc2 drivers/crypto/marvell/cipher.c Romain Perier 2016-06-21 385
bac8e805a30dc2 drivers/crypto/marvell/cipher.c Romain Perier 2016-06-21 386 if (ret)
bac8e805a30dc2 drivers/crypto/marvell/cipher.c Romain Perier 2016-06-21 387 goto err_free_tdma;
bac8e805a30dc2 drivers/crypto/marvell/cipher.c Romain Perier 2016-06-21 388
85030c5168f1df drivers/crypto/marvell/cipher.c Romain Perier 2016-06-21 389 basereq->chain.last->flags |= CESA_TDMA_END_OF_REQ;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 390
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 391 return 0;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 392
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 393 err_free_tdma:
53da740fed302f drivers/crypto/marvell/cipher.c Romain Perier 2016-06-21 394 mv_cesa_dma_cleanup(basereq);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 395 if (req->dst != req->src)
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 396 dma_unmap_sg(cesa_dev->dev, req->dst, creq->dst_nents,
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 397 DMA_FROM_DEVICE);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 398
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 399 err_unmap_src:
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 400 dma_unmap_sg(cesa_dev->dev, req->src, creq->src_nents,
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 401 req->dst != req->src ? DMA_TO_DEVICE : DMA_BIDIRECTIONAL);
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 402
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 403 return ret;
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 404 }
db509a45339fd7 drivers/crypto/marvell/cipher.c Boris Brezillon 2015-06-18 405
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-10-03 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 9:20 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-01 23:25 [PATCH 0/5] cesa: small cleanups Rosen Penev
2024-10-01 23:25 ` [PATCH 1/5] crypto: cesa: add COMPILE_TEST Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410031728.sQCYdNwD-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.