Re: [PATCH v2 2/2] usertools/telemetry: add new telemetry client

[Stephen Hemminger <stephen@networkplumber.org>]

On Wed, 31 Aug 2022 12:52:50 +0100
Conor Walsh <conor.walsh@intel.com> wrote:

> A lot of DPDK apps do not provide feedback to their users while
> running, but many interesting metrics are available through the
> app's telemetry socket. Currently, the main way to view these
> metrics is to query them using the dpdk-telemetry.py script.
> This is useful to check a few values or to check a value once.
> However, it is difficult to observe key values over time and it
> can be difficult to correctly parse JSON in one’s head!
> 
> It is proposed to add a new Python tool to usertools that will
> provide our users with a real-time, easy and visually appealing
> way to view statistics without leaving their terminals.
> The tool can provide various key statistics about any DPDK app
> in real-time. Various real-time graphs are available (using plotext),
> which makes visualizing the metrics easier.
> 
> The tool runs completely in terminal and is responsive to any
> terminal size down to 80 characters.
> The TUI is provided using the rich Python module.
> 
> The tool is already being used by some of Intel’s DPDK developers
> internally and we feel that it could be useful for the wider
> DPDK community.
> 
> A talk about this new tool will be presented at DPDK userspace.
> 
> Screenshot: https://cwalsh.tech/dpdk/tui3.png
> 
> Signed-off-by: Conor Walsh <conor.walsh@intel.com>

This looks cool and works for me. Guess no one uses telemetry much
otherwise should have gotten accepted.

There are some python style things could be cleaned up:
$ flake8 --max-line-length=100 ./usertools/dpdk-telemetry-tui.py 
./usertools/dpdk-telemetry-tui.py:347:5: E125 continuation line with same indent as next logical line
./usertools/dpdk-telemetry-tui.py:397:41: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:398:40: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:399:49: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:399:82: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:539:45: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:540:43: E203 whitespace before ':'
./usertools/dpdk-telemetry-tui.py:580:5: E125 continuation line with same indent as next logical line
./usertools/dpdk-telemetry-tui.py:637:5: E303 too many blank lines (2)



Acked-by: Stephen Hemminger <stephen@networkplumber.org>