From: kernel test robot <lkp@intel.com>
To: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [cip:linux-4.4.y-cip-rt 5795/25052] fs/binfmt_em86.c:73:35: error: passing argument 2 of 'copy_strings_kernel' from incompatible pointer type
Date: Thu, 3 Oct 2024 23:08:21 +0800 [thread overview]
Message-ID: <202410032333.C3VpXmU9-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/cip/linux-cip.git linux-4.4.y-cip-rt
head: d51e63480f2a36ac1c3a542632e60e1e2bdc0119
commit: 9295a38a563cc625c2faabf069f21ddd31cbf980 [5795/25052] Add upstream swait
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241003/202410032333.C3VpXmU9-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241003/202410032333.C3VpXmU9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410032333.C3VpXmU9-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from arch/alpha/include/asm/bug.h:22:0,
from include/linux/bug.h:4,
from include/linux/thread_info.h:11,
from include/asm-generic/preempt.h:4,
from arch/alpha/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:63,
from include/linux/spinlock.h:50,
from include/linux/seqlock.h:35,
from include/linux/time.h:5,
from include/linux/stat.h:18,
from include/linux/module.h:10,
from fs/binfmt_em86.c:11:
include/linux/cpumask.h: In function 'cpumask_check':
include/linux/cpumask.h:117:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
WARN_ON_ONCE(cpu >= nr_cpumask_bits);
^
include/asm-generic/bug.h:111:27: note: in definition of macro 'WARN_ON_ONCE'
int __ret_warn_once = !!(condition); \
^~~~~~~~~
fs/binfmt_em86.c: In function 'load_em86':
>> fs/binfmt_em86.c:73:35: error: passing argument 2 of 'copy_strings_kernel' from incompatible pointer type [-Werror=incompatible-pointer-types]
retval = copy_strings_kernel(1, &i_arg, bprm);
^
In file included from fs/binfmt_em86.c:14:0:
include/linux/binfmts.h:116:12: note: expected 'const char * const*' but argument is of type 'char **'
extern int copy_strings_kernel(int argc, const char *const *argv,
^~~~~~~~~~~~~~~~~~~
fs/binfmt_em86.c:77:34: error: passing argument 2 of 'copy_strings_kernel' from incompatible pointer type [-Werror=incompatible-pointer-types]
retval = copy_strings_kernel(1, &i_name, bprm);
^
In file included from fs/binfmt_em86.c:14:0:
include/linux/binfmts.h:116:12: note: expected 'const char * const*' but argument is of type 'char **'
extern int copy_strings_kernel(int argc, const char *const *argv,
^~~~~~~~~~~~~~~~~~~
fs/binfmt_em86.c:68:2: warning: ignoring return value of 'remove_arg_zero', declared with attribute warn_unused_result [-Wunused-result]
remove_arg_zero(bprm);
^~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/copy_strings_kernel +73 fs/binfmt_em86.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 24
71613c3b871c5a Al Viro 2012-10-20 25 static int load_em86(struct linux_binprm *bprm)
^1da177e4c3f41 Linus Torvalds 2005-04-16 26 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 27 char *interp, *i_name, *i_arg;
^1da177e4c3f41 Linus Torvalds 2005-04-16 28 struct file * file;
^1da177e4c3f41 Linus Torvalds 2005-04-16 29 int retval;
^1da177e4c3f41 Linus Torvalds 2005-04-16 30 struct elfhdr elf_ex;
^1da177e4c3f41 Linus Torvalds 2005-04-16 31
^1da177e4c3f41 Linus Torvalds 2005-04-16 32 /* Make sure this is a Linux/Intel ELF executable... */
^1da177e4c3f41 Linus Torvalds 2005-04-16 33 elf_ex = *((struct elfhdr *)bprm->buf);
^1da177e4c3f41 Linus Torvalds 2005-04-16 34
^1da177e4c3f41 Linus Torvalds 2005-04-16 35 if (memcmp(elf_ex.e_ident, ELFMAG, SELFMAG) != 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16 36 return -ENOEXEC;
^1da177e4c3f41 Linus Torvalds 2005-04-16 37
^1da177e4c3f41 Linus Torvalds 2005-04-16 38 /* First of all, some simple consistency checks */
^1da177e4c3f41 Linus Torvalds 2005-04-16 39 if ((elf_ex.e_type != ET_EXEC && elf_ex.e_type != ET_DYN) ||
^1da177e4c3f41 Linus Torvalds 2005-04-16 40 (!((elf_ex.e_machine == EM_386) || (elf_ex.e_machine == EM_486))) ||
72c2d531920048 Al Viro 2013-09-22 41 !bprm->file->f_op->mmap) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 42 return -ENOEXEC;
^1da177e4c3f41 Linus Torvalds 2005-04-16 43 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 44
51f39a1f0cea1c David Drysdale 2014-12-12 45 /* Need to be able to load the file after exec */
51f39a1f0cea1c David Drysdale 2014-12-12 46 if (bprm->interp_flags & BINPRM_FLAGS_PATH_INACCESSIBLE)
51f39a1f0cea1c David Drysdale 2014-12-12 47 return -ENOENT;
51f39a1f0cea1c David Drysdale 2014-12-12 48
^1da177e4c3f41 Linus Torvalds 2005-04-16 49 allow_write_access(bprm->file);
^1da177e4c3f41 Linus Torvalds 2005-04-16 50 fput(bprm->file);
^1da177e4c3f41 Linus Torvalds 2005-04-16 51 bprm->file = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 52
^1da177e4c3f41 Linus Torvalds 2005-04-16 53 /* Unlike in the script case, we don't have to do any hairy
^1da177e4c3f41 Linus Torvalds 2005-04-16 54 * parsing to find our interpreter... it's hardcoded!
^1da177e4c3f41 Linus Torvalds 2005-04-16 55 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 56 interp = EM86_INTERP;
^1da177e4c3f41 Linus Torvalds 2005-04-16 57 i_name = EM86_I_NAME;
^1da177e4c3f41 Linus Torvalds 2005-04-16 58 i_arg = NULL; /* We reserve the right to add an arg later */
^1da177e4c3f41 Linus Torvalds 2005-04-16 59
^1da177e4c3f41 Linus Torvalds 2005-04-16 60 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 61 * Splice in (1) the interpreter's name for argv[0]
^1da177e4c3f41 Linus Torvalds 2005-04-16 62 * (2) (optional) argument to interpreter
^1da177e4c3f41 Linus Torvalds 2005-04-16 63 * (3) filename of emulated file (replace argv[0])
^1da177e4c3f41 Linus Torvalds 2005-04-16 64 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 65 * This is done in reverse order, because of how the
^1da177e4c3f41 Linus Torvalds 2005-04-16 66 * user environment and arguments are stored.
^1da177e4c3f41 Linus Torvalds 2005-04-16 67 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 68 remove_arg_zero(bprm);
^1da177e4c3f41 Linus Torvalds 2005-04-16 69 retval = copy_strings_kernel(1, &bprm->filename, bprm);
^1da177e4c3f41 Linus Torvalds 2005-04-16 70 if (retval < 0) return retval;
^1da177e4c3f41 Linus Torvalds 2005-04-16 71 bprm->argc++;
^1da177e4c3f41 Linus Torvalds 2005-04-16 72 if (i_arg) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 @73 retval = copy_strings_kernel(1, &i_arg, bprm);
^1da177e4c3f41 Linus Torvalds 2005-04-16 74 if (retval < 0) return retval;
^1da177e4c3f41 Linus Torvalds 2005-04-16 75 bprm->argc++;
^1da177e4c3f41 Linus Torvalds 2005-04-16 76 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 77 retval = copy_strings_kernel(1, &i_name, bprm);
^1da177e4c3f41 Linus Torvalds 2005-04-16 78 if (retval < 0) return retval;
^1da177e4c3f41 Linus Torvalds 2005-04-16 79 bprm->argc++;
^1da177e4c3f41 Linus Torvalds 2005-04-16 80
^1da177e4c3f41 Linus Torvalds 2005-04-16 81 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 82 * OK, now restart the process with the interpreter's inode.
^1da177e4c3f41 Linus Torvalds 2005-04-16 83 * Note that we use open_exec() as the name is now in kernel
^1da177e4c3f41 Linus Torvalds 2005-04-16 84 * space, and we don't need to copy it.
^1da177e4c3f41 Linus Torvalds 2005-04-16 85 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 86 file = open_exec(interp);
^1da177e4c3f41 Linus Torvalds 2005-04-16 87 if (IS_ERR(file))
^1da177e4c3f41 Linus Torvalds 2005-04-16 88 return PTR_ERR(file);
^1da177e4c3f41 Linus Torvalds 2005-04-16 89
^1da177e4c3f41 Linus Torvalds 2005-04-16 90 bprm->file = file;
^1da177e4c3f41 Linus Torvalds 2005-04-16 91
^1da177e4c3f41 Linus Torvalds 2005-04-16 92 retval = prepare_binprm(bprm);
^1da177e4c3f41 Linus Torvalds 2005-04-16 93 if (retval < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16 94 return retval;
^1da177e4c3f41 Linus Torvalds 2005-04-16 95
3c456bfc4ba66e Al Viro 2012-10-20 96 return search_binary_handler(bprm);
^1da177e4c3f41 Linus Torvalds 2005-04-16 97 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 98
:::::: The code at line 73 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-10-03 15:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410032333.C3VpXmU9-lkp@intel.com \
--to=lkp@intel.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.