From: Stephen Hemminger <stephen@networkplumber.org>
To: Euan Bourke <euan.bourke@intel.com>
Cc: dev@dpdk.org, David Hunt <david.hunt@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Subject: Re: [PATCH v4 8/8] examples/l3fwd-power: update to call arg parser API
Date: Fri, 4 Oct 2024 09:05:49 -0700 [thread overview]
Message-ID: <20241004090549.4ac1bbe6@hermes.local> (raw)
In-Reply-To: <20231215172632.3102502-9-euan.bourke@intel.com>
On Fri, 15 Dec 2023 17:26:32 +0000
Euan Bourke <euan.bourke@intel.com> wrote:
> Update to the l3fwd-power example application to call the arg parser
> library for its 'combined core string parser' instead of implementing its
> own corelist parser. The default_type passed into the function call is
> a corelist.
>
> Signed-off-by: Euan Bourke <euan.bourke@intel.com>
> Acked-by: David Hunt <david.hunt@intel.com>
> ---
Compile test failed with older Gcc??
*Build Failed #1:
OS: CentOS79-64
Target: x86_64-native-linuxapp-gcc
FAILED: lib/librte_arg_parser.a.p/arg_parser_arg_parser.c.o
gcc -Ilib/librte_arg_parser.a.p -Ilib -I../lib -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/arg_parser -I../lib/arg_parser -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -DRTE_LOG_DEFAULT_LOGTYPE=lib.arg_parser -MD -MQ lib/librte_arg_parser.a.p/arg_parser_arg_parser.c.o -MF lib/librte_arg_parser.a.p/arg_parser_arg_parser.c.o.d -o lib/librte_arg_parser.a.p/arg_parser_arg_parser.c.o -c ../lib/arg_parser/arg_parser.c
../lib/arg_parser/arg_parser.c: In function ‘rte_arg_parse_corelist’:
../lib/arg_parser/arg_parser.c:76:9: error: missing braces around initializer [-Werror=missing-braces]
struct core_bits mask = {0};
^
../lib/arg_parser/arg_parser.c:76:9: error: (near initialization for ‘mask.bits’) [-Werror=missing-braces]
../lib/arg_parser/arg_parser.c: In function ‘rte_arg_parse_coremask’:
../lib/arg_parser/arg_parser.c:125:9: error: missing braces around initializer [-Werror=missing-braces]
struct core_bits mask = {0};
^
../lib/arg_parser/arg_parser.c:125:9: error: (near initialization for ‘mask.bits’) [-Werror=missing-braces]
cc1: all warnings being treated as errors
[2/2834] Compiling C object lib/librte_log.a.p/log_log_linux.c.o
[3/2834] Compiling C object lib/librte_eal.a.p/eal_common_eal_common_class.c.o
[4/2834] Compiling C object lib/librte_kvargs.a.p/kvargs_rte_kvargs.c.o
[5/2834] Compiling C object lib/librte_telemetry.a.p/telemetry_telemetry_data.c.o
[6/2834] Compiling C object lib/librte_telemetry.a.p/telemetry_telemetry_legacy.c.o
[7/2834] Compiling C object lib/librte_log.a.p/log_log.c.o
[8/2834] Compiling C object lib/librte_eal.a.p/eal_common_eal_common_bus.c.o
[9/2834] Compiling C object lib/librte_mempool.a.p/mempool_rte_mempool_ops_default.c.o
[10/2834] Compiling C object lib/librte_telemetry.a.p/telemetry_telemetry.c.o
ninja: build stopped
next prev parent reply other threads:[~2024-10-04 16:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <https://inbox.dpdk.org/dev/20231207161818.2590661-1-euan.bourke@intel.com/>
2023-12-15 17:26 ` [PATCH v4 0/8] add new command line argument parsing library Euan Bourke
2023-12-15 17:26 ` [PATCH v4 1/8] arg_parser: new library for command line parsing Euan Bourke
2024-01-24 13:16 ` Morten Brørup
2024-01-24 13:31 ` Bruce Richardson
2023-12-15 17:26 ` [PATCH v4 2/8] arg_parser: add new coremask parsing API Euan Bourke
2023-12-15 17:26 ` [PATCH v4 3/8] eal: add support for new arg parsing library Euan Bourke
2023-12-15 17:26 ` [PATCH v4 4/8] eal: update to service core related parsers Euan Bourke
2023-12-15 17:26 ` [PATCH v4 5/8] event/dlb2: add new arg parsing library API support Euan Bourke
2023-12-15 17:26 ` [PATCH v4 6/8] arg_parser: added common core string and heuristic parsers Euan Bourke
2023-12-15 17:26 ` [PATCH v4 7/8] examples/eventdev_pipeline: update to call arg parser API Euan Bourke
2023-12-15 17:26 ` [PATCH v4 8/8] examples/l3fwd-power: " Euan Bourke
2023-12-18 3:14 ` Tummala, Sivaprasad
2024-10-04 16:05 ` Stephen Hemminger [this message]
2023-12-15 21:53 ` [PATCH v4 0/8] add new command line argument parsing library Stephen Hemminger
2023-12-18 9:18 ` Bruce Richardson
2024-01-24 13:33 ` Thomas Monjalon
2024-02-14 17:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004090549.4ac1bbe6@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=euan.bourke@intel.com \
--cc=sivaprasad.tummala@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.