From: Jakub Kicinski <kuba@kernel.org>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: edumazet@google.com, atenart@kernel.org, davem@davemloft.net,
pabeni@redhat.com, dsahern@kernel.org,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
dongml2@chinatelecom.cn, bigeasy@linutronix.de, toke@redhat.com,
idosch@nvidia.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH net-next 1/7] net: ip: add drop reason to ip_route_input_noref()
Date: Fri, 4 Oct 2024 09:36:41 -0700 [thread overview]
Message-ID: <20241004093641.7f68b889@kernel.org> (raw)
In-Reply-To: <20241001060005.418231-2-dongml2@chinatelecom.cn>
no longer applies, please respin
On Tue, 1 Oct 2024 13:59:59 +0800 Menglong Dong wrote:
> + enum skb_drop_reason drop_reason = SKB_DROP_REASON_NOT_SPECIFIED;
> const struct iphdr *iph = ip_hdr(skb);
> - int err, drop_reason;
> + int err;
> struct rtable *rt;
reverse xmas tree
>
> - drop_reason = SKB_DROP_REASON_NOT_SPECIFIED;
> -
> if (ip_can_use_hint(skb, iph, hint)) {
> err = ip_route_use_hint(skb, iph->daddr, iph->saddr, iph->tos,
> dev, hint);
> @@ -363,7 +362,7 @@ static int ip_rcv_finish_core(struct net *net, struct sock *sk,
> */
> if (!skb_valid_dst(skb)) {
> err = ip_route_input_noref(skb, iph->daddr, iph->saddr,
> - iph->tos, dev);
> + iph->tos, dev, &drop_reason);
I find the extra output argument quite ugly.
I can't apply this now to try to suggest something better, perhaps you
can come up with a better solution..
--
pw-bot: cr
next prev parent reply other threads:[~2024-10-04 16:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 5:59 [PATCH net-next 0/7] net: ip: add drop reasons to input route Menglong Dong
2024-10-01 5:59 ` [PATCH net-next 1/7] net: ip: add drop reason to ip_route_input_noref() Menglong Dong
2024-10-04 16:36 ` Jakub Kicinski [this message]
2024-10-04 16:53 ` Eric Dumazet
2024-10-06 4:12 ` Menglong Dong
2024-10-01 6:00 ` [PATCH net-next 2/7] net: ip: add drop reason to ip_route_input_rcu() Menglong Dong
2024-10-01 6:00 ` [PATCH net-next 3/7] net: ip: add drop reason to ip_route_input_slow() Menglong Dong
2024-10-01 6:00 ` [PATCH net-next 4/7] net: ip: make fib_validate_source() return drop reason Menglong Dong
2024-10-01 6:00 ` [PATCH net-next 5/7] net: ip: make ip_route_input_mc() " Menglong Dong
2024-10-01 6:00 ` [PATCH net-next 6/7] net: ip: make ip_mc_validate_source() " Menglong Dong
2024-10-01 6:00 ` [PATCH net-next 7/7] net: ip: fix typo in the doc of SKB_DROP_REASON_IP_INNOROUTES Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004093641.7f68b889@kernel.org \
--to=kuba@kernel.org \
--cc=atenart@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dongml2@chinatelecom.cn \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=idosch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.