From: Jakub Kicinski <kuba@kernel.org>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: idosch@nvidia.com, aleksander.lobakin@intel.com,
horms@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, dsahern@kernel.org, dongml2@chinatelecom.cn,
amcohen@nvidia.com, gnault@redhat.com, bpoirier@nvidia.com,
b.galvani@gmail.com, razor@blackwall.org, petrm@nvidia.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 03/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper
Date: Fri, 4 Oct 2024 09:43:14 -0700 [thread overview]
Message-ID: <20241004094314.735bb69c@kernel.org> (raw)
In-Reply-To: <20241001073225.807419-4-dongml2@chinatelecom.cn>
On Tue, 1 Oct 2024 15:32:16 +0800 Menglong Dong wrote:
> -static inline bool skb_vlan_inet_prepare(struct sk_buff *skb,
> - bool inner_proto_inherit)
> +static inline enum skb_drop_reason
> +skb_vlan_inet_prepare_reason(struct sk_buff *skb, bool inner_proto_inherit)
this only has 5 callers, please convert them to expect a drop
reason to be returned instead of adding a compatibility wrapper
--
pw-bot: cr
next prev parent reply other threads:[~2024-10-04 16:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 7:32 [PATCH net-next v4 00/12] net: vxlan: add skb drop reasons support Menglong Dong
2024-10-01 7:32 ` [PATCH net-next v4 01/12] net: skb: add pskb_network_may_pull_reason() helper Menglong Dong
2024-10-02 13:36 ` Simon Horman
2024-10-01 7:32 ` [PATCH net-next v4 02/12] net: tunnel: add pskb_inet_may_pull_reason() helper Menglong Dong
2024-10-02 13:37 ` Simon Horman
2024-10-03 3:11 ` Kalesh Anakkur Purayil
2024-10-01 7:32 ` [PATCH net-next v4 03/12] net: tunnel: add skb_vlan_inet_prepare_reason() helper Menglong Dong
2024-10-02 13:37 ` Simon Horman
2024-10-04 16:43 ` Jakub Kicinski [this message]
2024-10-06 3:51 ` Menglong Dong
2024-10-01 7:32 ` [PATCH net-next v4 04/12] net: vxlan: add skb drop reasons to vxlan_rcv() Menglong Dong
2024-10-02 13:37 ` Simon Horman
2024-10-01 7:32 ` [PATCH net-next v4 05/12] net: vxlan: make vxlan_remcsum() return drop reasons Menglong Dong
2024-10-02 13:38 ` Simon Horman
2024-10-03 3:09 ` Kalesh Anakkur Purayil
2024-10-01 7:32 ` [PATCH net-next v4 06/12] net: vxlan: make vxlan_snoop() " Menglong Dong
2024-10-02 13:35 ` Simon Horman
2024-10-03 1:40 ` Menglong Dong
2024-10-01 7:32 ` [PATCH net-next v4 07/12] net: vxlan: make vxlan_set_mac() " Menglong Dong
2024-10-02 13:38 ` Simon Horman
2024-10-04 16:46 ` Jakub Kicinski
2024-10-06 3:52 ` Menglong Dong
2024-10-01 7:32 ` [PATCH net-next v4 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit() Menglong Dong
2024-10-02 13:38 ` Simon Horman
2024-10-04 16:45 ` Jakub Kicinski
2024-10-06 3:52 ` Menglong Dong
2024-10-01 7:32 ` [PATCH net-next v4 09/12] net: vxlan: add drop reasons support to vxlan_xmit_one() Menglong Dong
2024-10-02 13:38 ` Simon Horman
2024-10-01 7:32 ` [PATCH net-next v4 10/12] net: vxlan: use kfree_skb_reason() in vxlan_mdb_xmit() Menglong Dong
2024-10-02 13:39 ` Simon Horman
2024-10-01 7:32 ` [PATCH net-next v4 11/12] net: vxlan: use kfree_skb_reason() in vxlan_encap_bypass() Menglong Dong
2024-10-02 13:39 ` Simon Horman
2024-10-01 7:32 ` [PATCH net-next v4 12/12] net: vxlan: use kfree_skb_reason() in encap_bypass_if_local() Menglong Dong
2024-10-02 13:39 ` Simon Horman
2024-10-03 3:08 ` Kalesh Anakkur Purayil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004094314.735bb69c@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=amcohen@nvidia.com \
--cc=b.galvani@gmail.com \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=dongml2@chinatelecom.cn \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.