From: Jakub Kicinski <kuba@kernel.org>
To: Ingo van Lil <inguin@gmx.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Dan Murphy <dmurphy@ti.com>,
Alexander Sverdlin <alexander.sverdlin@siemens.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net] net: phy: dp83869: fix memory corruption when enabling fiber
Date: Fri, 4 Oct 2024 11:22:02 -0700 [thread overview]
Message-ID: <20241004112202.60ef2bcc@kernel.org> (raw)
In-Reply-To: <20241002161807.440378-1-inguin@gmx.de>
On Wed, 2 Oct 2024 18:18:07 +0200 Ingo van Lil wrote:
> When configuring the fiber port, the DP83869 PHY driver incorrectly
> calls linkmode_set_bit() with a bit mask (1 << 10) rather than a bit
> number (10). This corrupts some other memory location -- in case of
> arm64 the priv pointer in the same structure.
>
> Since the advertising flags are updated from supported at the end of the
> function the incorrect line isn't needed at all and can be removed.
>
> Fixes: a29de52ba2a1 ("net: dp83869: Add ability to advertise Fiber connection")
> Signed-off-by: Ingo van Lil <inguin@gmx.de>
Applied, thanks!
--
pw-bot: accept
prev parent reply other threads:[~2024-10-04 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 16:18 [PATCH net] net: phy: dp83869: fix memory corruption when enabling fiber Ingo van Lil
2024-10-02 16:47 ` Sverdlin, Alexander
2024-10-02 17:01 ` Andrew Lunn
2024-10-04 18:22 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004112202.60ef2bcc@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.sverdlin@siemens.com \
--cc=andrew@lunn.ch \
--cc=dmurphy@ti.com \
--cc=inguin@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.