Re: [PATCH bpf-next] selftests, bpf: Skip MPLS test_tc_tunnel tests if MPLS is unavailable

[Simon Horman <horms@kernel.org>]

On Wed, Oct 02, 2024 at 02:07:54PM +0200, Daniel Borkmann wrote:
> [ +Alexis ]
> 
> On 9/27/24 2:05 PM, Simon Horman wrote:
> > If MPLS is not available in the kernel then skip MPLS tests.
> > 
> > This avoids the test failing in situations where the test is not
> > supported by the underlying kernel.
> > 
> > In the case where all tests are run, just skip over the MPLS tests
> > without altering the exit code of the overall test run - there
> > is only one exit code in this scenario.
> > 
> > In the case where a single test is run, exit with KSFT_SKIP (4).
> > 
> > In both cases log an informative message.
> > 
> > Signed-off-by: Simon Horman <horms@kernel.org>
> 
> Are you running this as part of net selftests / CI which is why you
> need this? (And if yes, why excluding MPLS?)

Hi Daniel,

No, this was observed when running the test in a different harness.
I can find out why MPLS is excluded, but my assumption is because
it is not otherwise needed by the distro kernel that is being tested.

I entirely understand if that makes this patch out of scope for upstream.
Although having it upstream would be useful downstream.

> Alexis is working on converting tests like these into our BPF CI into
> test_progs, I'm not sure whether we need to make that more
> complex unless there is a compelling reason to exclude MPLS?

If the MPLS test(s) can somehow be excluded then that may meet the needs of
the test environment where this was observed, but I would need to check.

...