From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: axboe@kernel.dk, brauner@kernel.org, djwong@kernel.org,
viro@zeniv.linux.org.uk, jack@suse.cz, dchinner@redhat.com,
hch@lst.de, cem@kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, hare@suse.de,
martin.petersen@oracle.com, catherine.hoang@oracle.com,
mcgrof@kernel.org, ritesh.list@gmail.com, ojaswin@linux.ibm.com
Subject: Re: [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid()
Date: Fri, 4 Oct 2024 14:34:10 +0200 [thread overview]
Message-ID: <20241004123410.GA19295@lst.de> (raw)
In-Reply-To: <20241004092254.3759210-4-john.g.garry@oracle.com>
On Fri, Oct 04, 2024 at 09:22:49AM +0000, John Garry wrote:
> Currently FMODE_CAN_ATOMIC_WRITE is set if the bdev can atomic write and
> the file is open for direct IO. This does not work if the file is not
> opened for direct IO, yet fcntl(O_DIRECT) is used on the fd later.
This sound like a bug fix for 6.12-rc?
The fix looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-10-04 12:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 9:22 [PATCH v7 0/8] block atomic writes for xfs John Garry
2024-10-04 9:22 ` [PATCH v7 1/8] block/fs: Pass an iocb to generic_atomic_write_valid() John Garry
2024-10-04 9:22 ` [PATCH v7 2/8] fs: Export generic_atomic_write_valid() John Garry
2024-10-04 9:22 ` [PATCH v7 3/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid() John Garry
2024-10-04 12:34 ` Christoph Hellwig [this message]
2024-10-04 12:45 ` John Garry
2024-10-04 9:22 ` [PATCH v7 4/8] fs: iomap: Atomic write support John Garry
2024-10-04 9:22 ` [PATCH v7 5/8] xfs: Support FS_XFLAG_ATOMICWRITES John Garry
2024-10-04 12:35 ` Christoph Hellwig
2024-10-04 13:07 ` John Garry
2024-10-07 5:42 ` Christoph Hellwig
2024-10-13 21:06 ` John Garry
2024-10-16 0:52 ` Darrick J. Wong
2024-10-04 9:22 ` [PATCH v7 6/8] xfs: Support atomic write for statx John Garry
2024-10-04 9:22 ` [PATCH v7 7/8] xfs: Validate atomic writes John Garry
2024-10-04 9:22 ` [PATCH v7 8/8] xfs: Support setting FMODE_CAN_ATOMIC_WRITE John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004123410.GA19295@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.