From: Jakub Kicinski <kuba@kernel.org>
To: Praveen Kaligineedi <pkaligineedi@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, willemb@google.com, jeroendb@google.com,
shailend@google.com, hramamurthy@google.com,
ziweixiao@google.com, shannon.nelson@amd.com
Subject: Re: [PATCH net-next v2 2/2] gve: adopt page pool for DQ RDA mode
Date: Fri, 4 Oct 2024 16:48:47 -0700 [thread overview]
Message-ID: <20241004164847.0a79e2b4@kernel.org> (raw)
In-Reply-To: <20241003163042.194168-3-pkaligineedi@google.com>
On Thu, 3 Oct 2024 09:30:42 -0700 Praveen Kaligineedi wrote:
> Also add a stat per ring to track page pool allocation failures.
Please implement qstats instead of dumping it in ethtool -S:
https://elixir.bootlin.com/linux/v6.12-rc1/source/include/net/netdev_queues.h#L11
https://docs.kernel.org/next/networking/netlink_spec/netdev.html#rx-alloc-fail-uint
--
pw-bot: cr
prev parent reply other threads:[~2024-10-04 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 16:30 [PATCH net-next v2 0/2] gve: adopt page pool Praveen Kaligineedi
2024-10-03 16:30 ` [PATCH net-next v2 1/2] gve: move DQO rx buffer management related code to a new file Praveen Kaligineedi
2024-10-04 22:40 ` Jacob Keller
2024-10-03 16:30 ` [PATCH net-next v2 2/2] gve: adopt page pool for DQ RDA mode Praveen Kaligineedi
2024-10-04 22:43 ` Jacob Keller
2024-10-04 23:48 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004164847.0a79e2b4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
--cc=shannon.nelson@amd.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.