From: Tom Rini <trini@konsulko.com>
To: Rasmus Villemoes <ravi@prevas.dk>
Cc: u-boot@lists.denx.de, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH 13/13] global_data.h: remove unnecesary include of cyclic.h
Date: Fri, 4 Oct 2024 11:15:00 -0600 [thread overview]
Message-ID: <20241004171500.GD4737@bill-the-cat> (raw)
In-Reply-To: <20241003212802.3810-14-ravi@prevas.dk>
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
On Thu, Oct 03, 2024 at 11:28:02PM +0200, Rasmus Villemoes wrote:
> Nothing in cyclic.h is needed to define struct global_data, so do not
> include that header.
>
> If any .c file relies on getting cyclic.h through asm/global_data.h,
> it needs to include it itself.
>
> Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-10-04 17:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 21:27 [PATCH 00/13] disentangling cyclic API from schedule() Rasmus Villemoes
2024-10-03 21:27 ` [PATCH 01/13] doc: cyclic: remove reference to WATCHDOG_RESET Rasmus Villemoes
2024-10-09 1:52 ` Simon Glass
2024-10-22 11:10 ` Stefan Roese
2024-10-03 21:27 ` [PATCH 02/13] cyclic: introduce u-boot/schedule.h Rasmus Villemoes
2024-10-09 1:52 ` Simon Glass
2024-10-09 11:08 ` Rasmus Villemoes
2024-10-09 21:13 ` Simon Glass
2024-10-22 11:11 ` Stefan Roese
2024-10-03 21:27 ` [PATCH 03/13] led: include cyclic.h in led_sw_blink.c Rasmus Villemoes
2024-10-09 1:52 ` Simon Glass
2024-10-22 11:11 ` Stefan Roese
2024-10-03 21:27 ` [PATCH 04/13] m68k: asm/ptrace.h: include linux/types.h Rasmus Villemoes
2024-10-04 17:14 ` Tom Rini
2024-10-22 11:11 ` Stefan Roese
2024-10-03 21:27 ` [PATCH 05/13] fs/cramfs: use schedule instead of cyclic_run as callback Rasmus Villemoes
2024-10-09 1:52 ` Simon Glass
2024-10-22 11:11 ` Stefan Roese
2024-10-03 21:27 ` [PATCH 06/13] test: dm: wdt: replace cyclic_run() by schedule() Rasmus Villemoes
2024-10-09 1:52 ` Simon Glass
2024-10-22 11:12 ` Stefan Roese
2024-10-03 21:27 ` [PATCH 07/13] cyclic: make cyclic_run static Rasmus Villemoes
2024-10-09 1:52 ` Simon Glass
2024-10-22 11:12 ` Stefan Roese
2024-10-03 21:27 ` [PATCH 08/13] watchdog.h: change include of cyclic.h to u-boot/schedule.h Rasmus Villemoes
2024-10-09 1:52 ` Simon Glass
2024-10-22 11:12 ` Stefan Roese
2024-10-03 21:27 ` [PATCH 09/13] lib/sha*: include u-boot/schedule.h instead of cyclic.h Rasmus Villemoes
2024-10-09 1:52 ` Simon Glass
2024-10-22 11:13 ` Stefan Roese
2024-10-03 21:27 ` [PATCH 10/13] i2c: rzg2l: include u-boot/schedule.h Rasmus Villemoes
2024-10-09 1:55 ` Simon Glass
2024-10-22 11:13 ` Stefan Roese
2024-10-03 21:28 ` [PATCH 11/13] ddr: altera: " Rasmus Villemoes
2024-10-09 1:52 ` Simon Glass
2024-10-22 11:13 ` Stefan Roese
2024-10-03 21:28 ` [PATCH 12/13] boot: cedit: " Rasmus Villemoes
2024-10-09 1:51 ` Simon Glass
2024-10-22 11:13 ` Stefan Roese
2024-10-03 21:28 ` [PATCH 13/13] global_data.h: remove unnecesary include of cyclic.h Rasmus Villemoes
2024-10-04 17:15 ` Tom Rini [this message]
2024-10-22 11:14 ` Stefan Roese
2024-10-04 11:20 ` [PATCH 00/13] disentangling cyclic API from schedule() Stefan Roese
2024-10-23 10:53 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004171500.GD4737@bill-the-cat \
--to=trini@konsulko.com \
--cc=ravi@prevas.dk \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.