From: Stephen Hemminger <stephen@networkplumber.org>
To: Oleksandr Nahnybida <oleksandrn@interfacemasters.com>
Cc: reshma.pattan@intel.com, dev@dpdk.org
Subject: Re: [PATCH 1/2] pcapng: fix handling of chained mbufs
Date: Fri, 4 Oct 2024 18:10:29 -0700 [thread overview]
Message-ID: <20241004181029.6de8f06d@hermes.local> (raw)
In-Reply-To: <7yrjcy7sk4nexcqynikybhjvpxlhhmlwvubngwqvib5o752sys@644loude6vbd>
On Fri, 13 Sep 2024 15:19:18 +0300
Oleksandr Nahnybida <oleksandrn@interfacemasters.com> wrote:
> The pcapng generates corrupted files when dealing with chained mbufs.
> This issue arises because in rte_pcapng_copy the length of the EPB block
> is incorrectly calculated using the data_len of the first mbuf instead
> of the pkt_len, despite that rte_pcapng_write_packets correctly writing
> the mbuf chain to disk.
>
> This fix ensures that the block length is calculated based on the pkt_len,
> aligning it with the actual data written to disk.
>
> Signed-off-by: Oleksandr Nahnybida <oleksandrn@interfacemaster.com>
Fixes: 8d23ce8f5ee9 ("pcapng: add new library for writing pcapng files")
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
prev parent reply other threads:[~2024-10-05 1:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 12:19 [PATCH 1/2] pcapng: fix handling of chained mbufs Oleksandr Nahnybida
2024-09-13 12:34 ` [PATCH v2 " Oleksandr Nahnybida
2024-09-13 13:06 ` [PATCH v2 2/2] test/pcapng: test " Oleksandr Nahnybida
2024-10-05 16:13 ` Stephen Hemminger
2024-10-11 12:38 ` David Marchand
2024-09-13 12:40 ` Oleksandr Nahnybida
2024-09-13 15:27 ` Stephen Hemminger
2024-09-13 12:54 ` Oleksandr Nahnybida
2024-09-13 15:25 ` [PATCH 1/2] pcapng: fix handling of " Stephen Hemminger
2024-10-05 1:10 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004181029.6de8f06d@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=oleksandrn@interfacemasters.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.