All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alexander Potapenko <glider@google.com>
Cc: bemenboshra2001@gmail.com, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com,
	nogikh@google.com, dvyukov@google.com, elver@google.com,
	pimyn@google.com,
	syzbot+8f282cce71948071c335@syzkaller.appspotmail.com
Subject: Re: [PATCH] usb: usbtmc: initialize memory written to device
Date: Fri, 4 Oct 2024 15:56:04 +0200	[thread overview]
Message-ID: <2024100449-guiding-pesky-566a@gregkh> (raw)
In-Reply-To: <CAG_fn=Vmn1UotDhpHr48_ENd+d12y0G-qR5Q4m5aTODN+tH8uw@mail.gmail.com>

On Fri, Oct 04, 2024 at 03:41:22PM +0200, Alexander Potapenko wrote:
> On Fri, Oct 4, 2024 at 2:57 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Oct 04, 2024 at 12:33:13PM +0000, Pimyn@web.codeaurora.org wrote:
> 
> Just curious, what's up with this @web.codeaurora.org address? It
> wasn't in the original patch, where did it come from? :)

You tell me, look at the original patch, it's in the email...

> > > Avoid kernel-usb-infoleak by initializing all memory written to device.
> > > The buffer length uses 32bit alignment which might cause some buffer
> > > data to be read without any initialization.
> > >
> > > Reported-by: syzbot+8f282cce71948071c335@syzkaller.appspotmail.com
> > > Closes: https://lore.kernel.org/all/0000000000006f6622061eb52dba@google.com/T/
> > > Signed-off-by: Pimyn Girgis <bemenboshra2001@gmail.com> (Google)
> > > ---
> > >  drivers/usb/class/usbtmc.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> >
> > The "From:" line of this commit is obviously not correct and does not
> > match this signed-off-by line.
> 
> Sorry, does it mean the "(Google)" part should be present in the From:
> line as well?

A valid email address should be in the "From:" line.

> > Also, as you are from google, just use your google.com email address
> > please.
> 
> Unfortunately Pimyn cannot send emails outside the @google.com domain.

Google has well-known facilities and abilities to handle this, please
use them and do not hide behind gmail accounts.

thanks,

greg k-h

  reply	other threads:[~2024-10-04 13:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 12:33 [PATCH] usb: usbtmc: initialize memory written to device Pimyn
2024-10-04 12:57 ` Greg KH
2024-10-04 13:41   ` Alexander Potapenko
2024-10-04 13:56     ` Greg KH [this message]
2024-10-04 12:58 ` Greg KH
2024-10-04 13:38   ` Ⲡⲟⲓⲙⲏⲛ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024100449-guiding-pesky-566a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bemenboshra2001@gmail.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nogikh@google.com \
    --cc=pimyn@google.com \
    --cc=syzbot+8f282cce71948071c335@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.