All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	linux-gpio@vger.kernel.org
Subject: [linusw-pinctrl:for-next 5/5] drivers/pinctrl/pinctrl-aw9523.c:988:8: error: use of undeclared label 'err_disable_vregs'
Date: Sat, 5 Oct 2024 13:41:29 +0800	[thread overview]
Message-ID: <202410051344.Js99f2o2-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git for-next
head:   8498e6b2b8524b52f94ab22d65b50cd4508673c7
commit: 8498e6b2b8524b52f94ab22d65b50cd4508673c7 [5/5] Merge branch 'devel' into for-next
config: i386-buildonly-randconfig-002-20241005 (https://download.01.org/0day-ci/archive/20241005/202410051344.Js99f2o2-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410051344.Js99f2o2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410051344.Js99f2o2-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/pinctrl/pinctrl-aw9523.c:988:8: error: use of undeclared label 'err_disable_vregs'
     988 |                 goto err_disable_vregs;
         |                      ^
   1 error generated.


vim +/err_disable_vregs +988 drivers/pinctrl/pinctrl-aw9523.c

576623d706613f AngeloGioacchino Del Regno 2024-03-01   951  
576623d706613f AngeloGioacchino Del Regno 2024-03-01   952  static int aw9523_probe(struct i2c_client *client)
576623d706613f AngeloGioacchino Del Regno 2024-03-01   953  {
576623d706613f AngeloGioacchino Del Regno 2024-03-01   954  	struct device *dev = &client->dev;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   955  	struct pinctrl_desc *pdesc;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   956  	struct aw9523 *awi;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   957  	int ret;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   958  
576623d706613f AngeloGioacchino Del Regno 2024-03-01   959  	awi = devm_kzalloc(dev, sizeof(*awi), GFP_KERNEL);
576623d706613f AngeloGioacchino Del Regno 2024-03-01   960  	if (!awi)
576623d706613f AngeloGioacchino Del Regno 2024-03-01   961  		return -ENOMEM;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   962  
576623d706613f AngeloGioacchino Del Regno 2024-03-01   963  	i2c_set_clientdata(client, awi);
576623d706613f AngeloGioacchino Del Regno 2024-03-01   964  
576623d706613f AngeloGioacchino Del Regno 2024-03-01   965  	awi->dev = dev;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   966  	awi->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
576623d706613f AngeloGioacchino Del Regno 2024-03-01   967  	if (IS_ERR(awi->reset_gpio))
576623d706613f AngeloGioacchino Del Regno 2024-03-01   968  		return PTR_ERR(awi->reset_gpio);
576623d706613f AngeloGioacchino Del Regno 2024-03-01   969  	gpiod_set_consumer_name(awi->reset_gpio, "aw9523 reset");
576623d706613f AngeloGioacchino Del Regno 2024-03-01   970  
576623d706613f AngeloGioacchino Del Regno 2024-03-01   971  	awi->regmap = devm_regmap_init_i2c(client, &aw9523_regmap);
576623d706613f AngeloGioacchino Del Regno 2024-03-01   972  	if (IS_ERR(awi->regmap))
576623d706613f AngeloGioacchino Del Regno 2024-03-01   973  		return PTR_ERR(awi->regmap);
576623d706613f AngeloGioacchino Del Regno 2024-03-01   974  
38e2d33f134055 Rosen Penev                2024-10-01   975  	awi->vio_vreg = devm_regulator_get_enable_optional(dev, "vio");
38e2d33f134055 Rosen Penev                2024-10-01   976  	if (awi->vio_vreg && awi->vio_vreg != -ENODEV)
38e2d33f134055 Rosen Penev                2024-10-01   977  		return awi->vio_vreg;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   978  
7b2a96de50d04a Rosen Penev                2024-10-03   979  	ret = devm_mutex_init(dev, &awi->i2c_lock);
576623d706613f AngeloGioacchino Del Regno 2024-03-01   980  	if (ret)
576623d706613f AngeloGioacchino Del Regno 2024-03-01   981  		return ret;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   982  
4aad0ad20f4ea8 Andy Shevchenko            2024-03-29   983  	lockdep_set_subclass(&awi->i2c_lock, i2c_adapter_depth(client->adapter));
576623d706613f AngeloGioacchino Del Regno 2024-03-01   984  
576623d706613f AngeloGioacchino Del Regno 2024-03-01   985  	pdesc = devm_kzalloc(dev, sizeof(*pdesc), GFP_KERNEL);
393c554093c0c4 Rosen Penev                2024-10-01   986  	if (!pdesc) {
393c554093c0c4 Rosen Penev                2024-10-01   987  		ret = -ENOMEM;
393c554093c0c4 Rosen Penev                2024-10-01  @988  		goto err_disable_vregs;
393c554093c0c4 Rosen Penev                2024-10-01   989  	}
576623d706613f AngeloGioacchino Del Regno 2024-03-01   990  
576623d706613f AngeloGioacchino Del Regno 2024-03-01   991  	ret = aw9523_hw_init(awi);
576623d706613f AngeloGioacchino Del Regno 2024-03-01   992  	if (ret)
7b2a96de50d04a Rosen Penev                2024-10-03   993  		return ret;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   994  
576623d706613f AngeloGioacchino Del Regno 2024-03-01   995  	pdesc->name = dev_name(dev);
576623d706613f AngeloGioacchino Del Regno 2024-03-01   996  	pdesc->owner = THIS_MODULE;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   997  	pdesc->pctlops = &aw9523_pinctrl_ops;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   998  	pdesc->pmxops  = &aw9523_pinmux_ops;
576623d706613f AngeloGioacchino Del Regno 2024-03-01   999  	pdesc->confops = &aw9523_pinconf_ops;
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1000  	pdesc->pins = aw9523_pins;
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1001  	pdesc->npins = ARRAY_SIZE(aw9523_pins);
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1002  
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1003  	ret = aw9523_init_gpiochip(awi, pdesc->npins);
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1004  	if (ret)
7b2a96de50d04a Rosen Penev                2024-10-03  1005  		return ret;
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1006  
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1007  	if (client->irq) {
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1008  		ret = aw9523_init_irq(awi, client->irq);
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1009  		if (ret)
7b2a96de50d04a Rosen Penev                2024-10-03  1010  			return ret;
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1011  	}
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1012  
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1013  	awi->pctl = devm_pinctrl_register(dev, pdesc, awi);
7b2a96de50d04a Rosen Penev                2024-10-03  1014  	if (IS_ERR(awi->pctl))
7b2a96de50d04a Rosen Penev                2024-10-03  1015  		return dev_err_probe(dev, PTR_ERR(awi->pctl),
7b2a96de50d04a Rosen Penev                2024-10-03  1016  				     "Cannot register pinctrl");
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1017  
7b2a96de50d04a Rosen Penev                2024-10-03  1018  	return devm_gpiochip_add_data(dev, &awi->gpio, awi);
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1019  }
576623d706613f AngeloGioacchino Del Regno 2024-03-01  1020  

:::::: The code at line 988 was first introduced by commit
:::::: 393c554093c0c4cbc8e2f178d36df169016384da pinctrl: aw9523: add missing mutex_destroy

:::::: TO: Rosen Penev <rosenp@gmail.com>
:::::: CC: Linus Walleij <linus.walleij@linaro.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-10-05  5:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202410051344.Js99f2o2-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.