All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Cc: oe-kbuild-all@lists.linux.dev,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Łukasz Bartosik" <ukaszb@chromium.org>,
	"Benson Leung" <bleung@chromium.org>,
	"Jameson Thies" <jthies@google.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v1 2/4] usb: typec: Add attribute file showing the USB Modes of the partner
Date: Sat, 5 Oct 2024 15:25:20 +0800	[thread overview]
Message-ID: <202410051504.tccjB1Cp-lkp@intel.com> (raw)
In-Reply-To: <20241004140440.1882311-3-heikki.krogerus@linux.intel.com>

Hi Heikki,

kernel test robot noticed the following build warnings:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.12-rc1 next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Heikki-Krogerus/usb-typec-Add-attribute-file-showing-the-USB-Modes-of-the-partner/20241004-230547
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/20241004140440.1882311-3-heikki.krogerus%40linux.intel.com
patch subject: [PATCH v1 2/4] usb: typec: Add attribute file showing the USB Modes of the partner
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241005/202410051504.tccjB1Cp-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410051504.tccjB1Cp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410051504.tccjB1Cp-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/usb/typec/class.c:630: warning: Function parameter or struct member 'usb_mode' not described in 'typec_partner_set_usb_mode'
>> drivers/usb/typec/class.c:630: warning: Excess function parameter 'mode' description in 'typec_partner_set_usb_mode'


vim +630 drivers/usb/typec/class.c

   620	
   621	/**
   622	 * typec_partner_set_usb_mode - Assign active USB Mode for the partner
   623	 * @partner: USB Type-C partner
   624	 * @mode: USB Mode (USB2, USB3 or USB4)
   625	 *
   626	 * The port drivers can use this function to assign the active USB Mode to
   627	 * @partner. The USB Mode can change for example due to Data Reset.
   628	 */
   629	void typec_partner_set_usb_mode(struct typec_partner *partner, enum usb_mode usb_mode)
 > 630	{
   631		if (!partner || partner->usb_mode == usb_mode)
   632			return;
   633	
   634		partner->usb_capability |= BIT(usb_mode - 1);
   635		partner->usb_mode = usb_mode;
   636		sysfs_notify(&partner->dev.kobj, NULL, "usb_mode");
   637	}
   638	EXPORT_SYMBOL_GPL(typec_partner_set_usb_mode);
   639	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2024-10-05  7:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 14:04 [PATCH v1 0/3] usb: typec: USB Modes Heikki Krogerus
2024-10-04 14:04 ` [PATCH v1 1/4] usb: typec: Add attribute file showing the supported USB modes of the port Heikki Krogerus
2024-10-06 16:35   ` Dmitry Baryshkov
2024-10-04 14:04 ` [PATCH v1 2/4] usb: typec: Add attribute file showing the USB Modes of the partner Heikki Krogerus
2024-10-05  7:25   ` kernel test robot [this message]
2024-10-06 16:22   ` Dmitry Baryshkov
2024-10-09  8:34     ` Heikki Krogerus
2024-10-04 14:04 ` [PATCH v1 3/4] usb: typec: ucsi: Supply the USB capabilities to the ports Heikki Krogerus
2024-10-06 16:36   ` Dmitry Baryshkov
2024-10-04 14:04 ` [PATCH v1 4/4] usb: typec: ucsi: Add support for the partner USB Modes Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202410051504.tccjB1Cp-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=abhishekpandit@chromium.org \
    --cc=bleung@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jthies@google.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=ukaszb@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.