From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <gnaaman@drivenets.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH net-next v2 1/2] Convert neighbour-table to use hlist
Date: Sun, 6 Oct 2024 08:56:45 -0700 [thread overview]
Message-ID: <20241006155645.58445-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20241006064747.201773-2-gnaaman@drivenets.com>
From: Gilad Naaman <gnaaman@drivenets.com>
Date: Sun, 6 Oct 2024 06:47:42 +0000
> @@ -2728,9 +2695,7 @@ static int neigh_dump_table(struct neigh_table *tbl, struct sk_buff *skb,
> for (h = s_h; h < (1 << nht->hash_shift); h++) {
> if (h > s_h)
> s_idx = 0;
> - for (n = rcu_dereference(nht->hash_buckets[h]), idx = 0;
> - n != NULL;
> - n = rcu_dereference(n->next)) {
> + hlist_for_each_entry_rcu(n, &nht->hash_buckets[h], list) {
idx = 0 was accidentally removed.
> if (idx < s_idx || !net_eq(dev_net(n->dev), net))
> goto next;
> if (neigh_ifindex_filtered(n->dev, filter->dev_idx) ||
next prev parent reply other threads:[~2024-10-06 15:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 6:47 [PATCH net-next v2 0/2] Improve neigh_flush_dev performance Gilad Naaman
2024-10-06 6:47 ` [PATCH net-next v2 1/2] Convert neighbour-table to use hlist Gilad Naaman
2024-10-06 15:52 ` Kuniyuki Iwashima
2024-10-08 7:38 ` Gilad Naaman
2024-10-08 14:53 ` Kuniyuki Iwashima
2024-10-06 15:56 ` Kuniyuki Iwashima [this message]
2024-10-09 13:52 ` kernel test robot
2024-10-06 6:47 ` [PATCH net-next v2 2/2] Create netdev->neighbour association Gilad Naaman
2024-10-09 6:03 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241006155645.58445-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnaaman@drivenets.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.