All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	jason.andryuk@amd.com, christopher.w.clark@gmail.com,
	stefano.stabellini@amd.com, "Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v5 25/44] x86/boot: convert create_dom0 to use boot info
Date: Sun,  6 Oct 2024 17:49:36 -0400	[thread overview]
Message-ID: <20241006214956.24339-26-dpsmith@apertussolutions.com> (raw)
In-Reply-To: <20241006214956.24339-1-dpsmith@apertussolutions.com>

This commit changes create_dom0 to no longer take the individual components and
take struct boot_info instead. Internally, it is changed to locate the kernel
and ramdisk details from struct boot_info.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/arch/x86/setup.c | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 0d2ee19998aa..c2bcddc50990 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -946,10 +946,8 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li
     return n;
 }
 
-static struct domain *__init create_dom0(const module_t *image,
-                                         unsigned long headroom,
-                                         module_t *initrd, const char *kextra,
-                                         const char *loader)
+static struct domain *__init create_dom0(const struct boot_info *bi,
+                                         const char *kextra)
 {
     static char __initdata cmdline[MAX_GUEST_CMDLINE];
 
@@ -964,9 +962,21 @@ static struct domain *__init create_dom0(const module_t *image,
             .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0,
         },
     };
+    int headroom, mod_idx = first_boot_module_index(bi, BOOTMOD_RAMDISK);
+    module_t *image, *initrd;
     struct domain *d;
     domid_t domid;
 
+    /* Map boot_module to mb1 module for dom0 */
+    image = bi->mods[0].mod;
+    headroom = bi->mods[0].headroom;
+
+    /* Map boot_module to mb1 module for initrd */
+    if ( mod_idx < 0 )
+        initrd = NULL;
+    else
+        initrd = bi->mods[mod_idx].mod;
+
     if ( opt_dom0_pvh )
     {
         dom0_cfg.flags |= (XEN_DOMCTL_CDF_hvm |
@@ -995,7 +1005,7 @@ static struct domain *__init create_dom0(const module_t *image,
     if ( image->string || kextra )
     {
         if ( image->string )
-            safe_strcpy(cmdline, cmdline_cook(__va(image->string), loader));
+            safe_strcpy(cmdline, cmdline_cook(__va(image->string), bi->loader));
 
         if ( kextra )
             /* kextra always includes exactly one leading space. */
@@ -2106,10 +2116,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long mbi_p)
      * We're going to setup domain0 using the module(s) that we stashed safely
      * above our heap. The second module, if present, is an initrd ramdisk.
      */
-    dom0 = create_dom0(bi->mods[0].mod, bi->mods[0].headroom,
-                       (initrdidx >= 0 && initrdidx < bi->nr_modules) ?
-                            bi->mods[initrdidx].mod : NULL,
-                       kextra, bi->loader);
+    dom0 = create_dom0(bi, kextra);
     if ( !dom0 )
         panic("Could not set up DOM0 guest OS\n");
 
-- 
2.30.2



  parent reply	other threads:[~2024-10-06 21:57 UTC|newest]

Thread overview: 153+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-06 21:49 [PATCH v5 00/44] Boot modules for Hyperlaunch Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 01/44] x86/boot: move x86 boot module counting into a new boot_info struct Daniel P. Smith
2024-10-07 17:57   ` Jason Andryuk
2024-10-08  6:41     ` Jan Beulich
2024-10-09 11:15       ` Daniel P. Smith
2024-10-09 15:02     ` Jan Beulich
2024-10-06 21:49 ` [PATCH v5 02/44] x86/boot: move boot loader name to boot info Daniel P. Smith
2024-10-07 17:58   ` Jason Andryuk
2024-10-09 15:07   ` Jan Beulich
2024-10-10  0:55     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 03/44] x86/boot: move cmdline " Daniel P. Smith
2024-10-07 18:09   ` Jason Andryuk
2024-10-08  6:42     ` Jan Beulich
2024-10-09 11:28       ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 04/44] x86/boot: move mmap info " Daniel P. Smith
2024-10-07 18:10   ` Jason Andryuk
2024-10-09 15:13   ` Jan Beulich
2024-10-10  0:59     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 05/44] x86/boot: introduce struct boot_module Daniel P. Smith
2024-10-07 18:29   ` Jason Andryuk
2024-10-09 11:31     ` Daniel P. Smith
2024-10-09 15:17   ` Jan Beulich
2024-10-10  1:01     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 06/44] x86/boot: convert consider_modules to " Daniel P. Smith
2024-10-07 18:36   ` Jason Andryuk
2024-10-09 15:22   ` Jan Beulich
2024-10-10  1:02     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 07/44] x86/boot: move headroom to boot modules Daniel P. Smith
2024-10-07 18:55   ` Jason Andryuk
2024-10-09 11:46     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 08/44] x86/boot: convert setup.c mod refs to early_mod Daniel P. Smith
2024-10-07 19:34   ` Jason Andryuk
2024-10-09 14:23     ` Daniel P. Smith
2024-10-09 14:29       ` Jan Beulich
2024-10-09 14:31         ` Daniel P. Smith
2024-10-09 15:29   ` Jan Beulich
2024-10-10  1:07     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 09/44] x86/boot: introduce boot module types Daniel P. Smith
2024-10-07 19:50   ` Jason Andryuk
2024-10-09 14:25     ` Daniel P. Smith
2024-10-09 15:30   ` Jan Beulich
2024-10-10  1:11     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 10/44] x86/boot: introduce boot module flags Daniel P. Smith
2024-10-07 20:02   ` Jason Andryuk
2024-10-09 14:27     ` Daniel P. Smith
2024-10-09 15:32     ` Jan Beulich
2024-10-06 21:49 ` [PATCH v5 11/44] x86/boot: split bootstrap_map_addr() out of bootstrap_map() Daniel P. Smith
2024-10-07 20:04   ` Jason Andryuk
2024-10-09 15:38   ` Jan Beulich
2024-10-10  1:16     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 12/44] x86/boot: add start and size fields to struct boot_module Daniel P. Smith
2024-10-07 20:06   ` Jason Andryuk
2024-10-09 15:39   ` Jan Beulich
2024-10-10  1:23     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 13/44] x86/boot: update struct boot_module on module relocation Daniel P. Smith
2024-10-07 20:31   ` Jason Andryuk
2024-10-09 14:36     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 14/44] x86/boot: transition relocation calculations to struct boot_module Daniel P. Smith
2024-10-07 20:44   ` Jason Andryuk
2024-10-09 14:44     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 15/44] x86/boot: introduce boot module interator Daniel P. Smith
2024-10-07 20:59   ` Jason Andryuk
2024-10-09 15:53   ` Jan Beulich
2024-10-10  1:45     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 16/44] x86/boot: introduce consumed flag for struct boot_module Daniel P. Smith
2024-10-07 21:06   ` Jason Andryuk
2024-10-09 14:49     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 17/44] x86/boot: convert microcode loading to consume struct boot_info Daniel P. Smith
2024-10-07 21:22   ` Jason Andryuk
2024-10-08 12:50     ` Jason Andryuk
2024-10-09 14:58       ` Daniel P. Smith
2024-10-09 14:57     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 18/44] x86/boot: convert late microcode loading to struct boot_module Daniel P. Smith
2024-10-08 12:50   ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 19/44] x86/boot: use consumed boot module flag for microcode Daniel P. Smith
2024-10-08 15:56   ` Jason Andryuk
2024-10-09 16:29     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 20/44] x86/boot: convert xsm policy loading to struct boot_module Daniel P. Smith
2024-10-08 16:13   ` Jason Andryuk
2024-10-09 17:21     ` Daniel P. Smith
2024-10-10 17:23       ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 21/44] x86/boot: convert ramdisk locating " Daniel P. Smith
2024-10-08 16:26   ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 22/44] x86/boot: remove module_map usage from microcode loading Daniel P. Smith
2024-10-08 16:30   ` Jason Andryuk
2024-10-09 17:24     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 23/44] x86/boot: remove module_map usage from xsm policy loading Daniel P. Smith
2024-10-08 16:36   ` Jason Andryuk
2024-10-09 17:25     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 24/44] x86/boot: remove module_map usage by ramdisk loading Daniel P. Smith
2024-10-08 16:46   ` Jason Andryuk
2024-10-09 18:36     ` Daniel P. Smith
2024-10-06 21:49 ` Daniel P. Smith [this message]
2024-10-08 16:52   ` [PATCH v5 25/44] x86/boot: convert create_dom0 to use boot info Jason Andryuk
2024-10-09 23:02     ` Daniel P. Smith
2024-10-10  8:03       ` Jan Beulich
2024-10-10 10:41         ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 26/44] x86/boot: convert construct_dom0 to use struct boot_module Daniel P. Smith
2024-10-08 16:57   ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 27/44] x86/boot: relocate kextra into boot info Daniel P. Smith
2024-10-08 17:01   ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 28/44] x86/boot: add cmdline to struct boot_module Daniel P. Smith
2024-10-08 17:08   ` Jason Andryuk
2024-10-09 23:09     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 29/44] x86/boot: convert dom0_construct_pv image param " Daniel P. Smith
2024-10-08 18:03   ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 30/44] x86/boot: convert dom0_construct_pv initrd " Daniel P. Smith
2024-10-08 18:30   ` Jason Andryuk
2024-10-09 23:12     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 31/44] x86/boot: convert dom0_construct_pvh " Daniel P. Smith
2024-10-08 18:33   ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 32/44] x86/boot: convert pvh_load_kernel " Daniel P. Smith
2024-10-08 18:42   ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 33/44] x86/boot: convert initial_images " Daniel P. Smith
2024-10-08 18:52   ` Jason Andryuk
2024-10-09 23:15     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 34/44] x86/boot: drop the use of initial_images unit global Daniel P. Smith
2024-10-08 19:04   ` Jason Andryuk
2024-10-09 23:22     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 35/44] x86/boot: remove usage of mod_end by discard_initial_images Daniel P. Smith
2024-10-08 19:05   ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 36/44] x86/boot: remove remaining early_mod references Daniel P. Smith
2024-10-08 19:15   ` Jason Andryuk
2024-10-09  6:53     ` Jan Beulich
2024-10-09 23:42       ` Daniel P. Smith
2024-10-10  8:05         ` Jan Beulich
2024-10-09 23:40     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 37/44] x86/boot: remove mod from struct boot_module Daniel P. Smith
2024-10-08 19:16   ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 38/44] x86/boot: introduce boot domain Daniel P. Smith
2024-10-08 19:30   ` Jason Andryuk
2024-10-06 21:49 ` [PATCH v5 39/44] x86/boot: introduce domid field to struct boot_domain Daniel P. Smith
2024-10-08 19:31   ` Jason Andryuk
2024-10-08 19:36   ` Jason Andryuk
2024-10-09  6:54     ` Jan Beulich
2024-10-10  0:34     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 40/44] x86/boot: add cmdline " Daniel P. Smith
2024-10-08 20:05   ` Jason Andryuk
2024-10-10  0:45     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 41/44] x86/boot: add struct domain " Daniel P. Smith
2024-10-08 19:48   ` Jason Andryuk
2024-10-10  0:47     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 42/44] x86/boot: convert construct_dom0 " Daniel P. Smith
2024-10-08 19:47   ` Jason Andryuk
2024-10-10  0:48     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 43/44] x86/boot: convert dom0_construct_pv " Daniel P. Smith
2024-10-08 19:54   ` Jason Andryuk
2024-10-10  0:49     ` Daniel P. Smith
2024-10-06 21:49 ` [PATCH v5 44/44] x86/boot: convert dom0_construct_pvh " Daniel P. Smith
2024-10-08 19:56   ` Jason Andryuk
2024-10-10  0:51     ` Daniel P. Smith
2024-10-08 20:07 ` [PATCH v5 00/44] Boot modules for Hyperlaunch Jason Andryuk
2024-10-08 21:21   ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241006214956.24339-26-dpsmith@apertussolutions.com \
    --to=dpsmith@apertussolutions.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=christopher.w.clark@gmail.com \
    --cc=jason.andryuk@amd.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=stefano.stabellini@amd.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.