From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Christoph Hellwig <hch@lst.de>,
sagi@grimberg.me, kch@nvidia.com, d.bogdanov@yadro.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v11 1/1] nvmet: support reservation feature
Date: Mon, 7 Oct 2024 08:36:59 +0200 [thread overview]
Message-ID: <20241007063659.GA1112@lst.de> (raw)
In-Reply-To: <3fedef45-0714-4d5e-b256-60c5b7a65914@linux.alibaba.com>
On Sat, Oct 05, 2024 at 11:09:20PM +0800, Guixin Liu wrote:
>>> +struct nvmet_pr_register_data {
>>> + __le64 crkey;
>>> + __le64 nrkey;
>>> +};
>>> +
>>> +struct nvmet_pr_acquire_data {
>>> + __le64 crkey;
>>> + __le64 prkey;
>>> +};
>>> +
>>> +struct nvmet_pr_release_data {
>>> + __le64 crkey;
>>> +};
>> Using little endian fields for purely in-memory data feels strange.
>> Is there a good reason for this?
>>
> I use nvmet_copy_from_sgl to obtain the command's detail, just like
>
> nvme_dsm_range, maybe I can put them in to include/linux/nvme.h.
Ah right, you just store the on the wire format locally. Yes,
pleaße ad them to nvme.h.
prev parent reply other threads:[~2024-10-07 6:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 3:14 [PATCH v11 0/1] Implement the NVMe reservation feature Guixin Liu
2024-09-29 3:14 ` [PATCH v11 1/1] nvmet: support " Guixin Liu
2024-09-30 12:53 ` Dmitry Bogdanov
2024-10-05 14:26 ` Guixin Liu
2024-10-07 8:08 ` Dmitry Bogdanov
2024-10-08 7:27 ` Guixin Liu
2024-10-08 8:45 ` Dmitry Bogdanov
2024-10-08 9:25 ` Guixin Liu
2024-10-02 8:09 ` Christoph Hellwig
2024-10-05 15:09 ` Guixin Liu
2024-10-07 6:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007063659.GA1112@lst.de \
--to=hch@lst.de \
--cc=d.bogdanov@yadro.com \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.