From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37EE5CFB43F for ; Mon, 7 Oct 2024 08:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sCPYHjLA5Ek4wgNAJL6n36NKeJCc8KkCOYajlUQICIA=; b=UwvwqtrvlyK2dh Uz9uCi8xuynKXIVEMbHF6+02cMmMEPx23f+oSp/YmBwlpC14RMK7qYvoX22b8XnwJENX8aB5MpDvE B2n+eXUUdB+oNYC4vYFrKRuaY/aOQcBclSxG/GiFJonYEpGzDySUtabgs6jC8NrkCP+h7D9nkYLLc PR0QoVc6mcpKI5jIzrtFdTNd1y9piqjUnpHfsPVfrGi0rR6e6qnJivz9HAKwRRwOe8o8LTjNtDZ1I 2DMkh2+yaGVyFY5V3qa3EBaEICfGfpkpaLEZxJ+qG3zUM7KFzE6B+LqYxZ58mfzVv/YipWjvedb4p nBP984I0cqCRluV0RYvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxj9I-00000001m78-0ChZ; Mon, 07 Oct 2024 08:31:24 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxj9E-00000001m5u-2ULz for linux-mtd@lists.infradead.org; Mon, 07 Oct 2024 08:31:22 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id D0B75C0005; Mon, 7 Oct 2024 08:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1728289876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4rb0qAok+4nN5Eq9733pEqebLsnhZLk/VLDHYW7fziQ=; b=pXM8LD5c8H8QrgcQFgWuGAYamfTYSxpx9XiiylWBubTJHJUwAwR20s8mt/z1bc1JF5EzM5 uR6wBGGMd7TSNPCj0tZqBak9clIj7VtJH/1YITcLVYuse0S5EJCZnUeKGdGfTizl01jh/y cfGR6Rq6+bN0scEzcsP8IMeruuNUQHwiO4LzV2MQAmbzHqx3kNgDgG9yxnwdh6SACJ3ZkQ b52yTTfKCb5E5+plVm8utctGG7arqN7EnTzXh/4zsyTvfo0+OGqH1L5fqn7iWUbCqkpmk7 GFuDit5+EuJltoNgT5ty/1fEA50Mxtp/v1ldkbUFTlTPGk2Mm7m8myrOHwIj2Q== Date: Mon, 7 Oct 2024 10:31:14 +0200 From: Miquel Raynal To: Marcus Folkesson Cc: Krzysztof Kozlowski , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: davinci: convert to yaml Message-ID: <20241007103114.1a63e3e2@xps-13> In-Reply-To: References: <20241006-ondie-v4-0-ff9b9fd9a81d@gmail.com> <20241006-ondie-v4-2-ff9b9fd9a81d@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_013120_785274_29D52DC3 X-CRM114-Status: GOOD ( 14.17 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFyY3VzLAoKbWFyY3VzLmZvbGtlc3NvbkBnbWFpbC5jb20gd3JvdGUgb24gTW9uLCA3IE9j dCAyMDI0IDA4OjI5OjQ0ICswMjAwOgoKPiBPbiBNb24sIE9jdCAwNywgMjAyNCBhdCAwODowNzoy N0FNICswMjAwLCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+ID4gT24gU3VuLCBPY3QgMDYs IDIwMjQgYXQgMDM6MDU6NDdQTSArMDIwMCwgTWFyY3VzIEZvbGtlc3NvbiB3cm90ZTogIAo+ID4g PiArICB0aSxkYXZpbmNpLW5hbmQtdXNlLWJidDoKPiA+ID4gKyAgICB0eXBlOiBib29sZWFuCj4g PiA+ICsgICAgZGVzY3JpcHRpb246Cj4gPiA+ICsgICAgICBVc2UgZmxhc2ggYmFzZWQgYmFkIGJs b2NrIHRhYmxlIHN1cHBvcnQuIE9PQiBpZGVudGlmaWVyIGlzIHNhdmVkIGluIE9PQgo+ID4gPiAr ICAgICAgYXJlYS4KPiA+ID4gKyAgICBkZXByZWNhdGVkOiB0cnVlCj4gPiA+ICsKPiA+ID4gK3Jl cXVpcmVkOgo+ID4gPiArICAtIGNvbXBhdGlibGUKPiA+ID4gKyAgLSByZWcKPiA+ID4gKyAgLSB0 aSxkYXZpbmNpLWNoaXBzZWxlY3QKPiA+ID4gKwo+ID4gPiArYWRkaXRpb25hbFByb3BlcnRpZXM6 IHRydWUgIAo+ID4gCj4gPiBUaGF0J3MgYSBmaW5hbCBkZXZpY2Ugc2NoZW1hLCB0aGlzIGNhbm5v dCBiZSB0cnVlLiBXaHkgeW91IGFyZSBkb2luZwo+ID4gdGhpcyBlbnRpcmVseSBkaWZmZXJlbnQg dGhhbiBhbGwgb3RoZXIgYmluZGluZ3M/ICAKPiAKPiBGcm9tIG15IHVuZGVyc3RhbmRpbmcsIGFk ZGl0aW9uYWxQcm9wZXJ0aWVzIGlzIHRvIGluZGljYXRlIHRoYXQgdGhlCj4gc2NoZW1hIGNvdWxk IGNvbnRhaW4gcHJvcGVydGllcyB0aGF0IHdlcmUgbm90IGV4cGxpY2l0IGxpc3RlZCBoZXJlIGJ1 dAo+IGluaGVyaXRlZCBmcm9tIGUuZy4gbmFuZC1jb250cm9sbGVyLnlhbWwuCgphZGRpdGlvbmFs UHJvcGVydGllczogdHJ1ZSBtZWFucyB0aGVyZSBpcyBubyBjb250cm9sIG92ZXIgdGhlCnByb3Bl cnRpZXMgYWxsb3dlZCwgc28gd2UgZ2VuZXJhbGx5IGRvbid0IHdhbnQgdGhhdCAodW5sZXNzIHlv dSdyZQp3cml0aW5nIHNwZWNpZmljICJnZW5lcmljIiBiaW5kaW5ncywgd2hpY2ggaXMgbm90IHRo ZSBjYXNlIGhlcmUpLgoKWW91IGFyZSBkZXNjcmliaW5nIGEgY29udHJvbGxlciBzbyBoZXJlIHlv dSBzaG91bGQgcmVmZXJlbmNlIHRvCm5hbmQtY29udHJvbGxlci55YW1sLCBidXQgdGhlbiBwcmV2 ZW50IGFueSBwcm9wZXJ0eSBub3QgZGVmaW5lZCBpbgpuYW5kLWNvbnRyb2xsZXIueWFtbCBmcm9t IGJlaW5nIHVzZWQuIEluIHRoaXMgY2FzZSB5b3UgcHJvYmFibHkgd2FudCB0bwp0cnkgdW5ldmFs dWF0ZWRQcm9wZXJ0aWVzOiBmYWxzZSwgd2hpY2ggbWVhbnMgdGhhdCBhbnkgcHJvcGVydHkgbm90 Cmxpc3RlZCBoZXJlIG9yIGluIHRoZSByZWZlcmVuY2VkIHNjaGVtYXMgd2lsbCBiZSBwcm9oaWJp dGVkLgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3AA033FE; Mon, 7 Oct 2024 08:31:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728289886; cv=none; b=I5EIqekmhSPsCSXd9FS/As8BPScIHLvhN0yFTCdrsfXmXPHOjrLlFVYSnIHvQ6EfhzRdzTIPL6CHknR94nfo3uVmYbGV5L5qTOuSZdM1tDPArxzOK0UO72ATxSGeHkqyXwZMYS3cmNuWU1/uYM789HKky7tPMnEjQhCfJ75vpoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728289886; c=relaxed/simple; bh=u9xn5NKrPvn154tL338s4FqczjJox5o62NGI+xcQ0FY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dTUBgfuUq1B1pdI6X0BucFui06/9CH2tqaEhLVIu6Oa4SUDNdoc/8hiLEvYrzDYBtfkfm9WuuOiJQ7vNBf4kGcNC+PGViWXnyNEfCUw1knGbhDzREQ1FrGkgih9WXQLI+/raj9bdB7rCU8ZvrOkYNAC7HHRugSNraVeHt1izB8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=pXM8LD5c; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="pXM8LD5c" Received: by mail.gandi.net (Postfix) with ESMTPSA id D0B75C0005; Mon, 7 Oct 2024 08:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1728289876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4rb0qAok+4nN5Eq9733pEqebLsnhZLk/VLDHYW7fziQ=; b=pXM8LD5c8H8QrgcQFgWuGAYamfTYSxpx9XiiylWBubTJHJUwAwR20s8mt/z1bc1JF5EzM5 uR6wBGGMd7TSNPCj0tZqBak9clIj7VtJH/1YITcLVYuse0S5EJCZnUeKGdGfTizl01jh/y cfGR6Rq6+bN0scEzcsP8IMeruuNUQHwiO4LzV2MQAmbzHqx3kNgDgG9yxnwdh6SACJ3ZkQ b52yTTfKCb5E5+plVm8utctGG7arqN7EnTzXh/4zsyTvfo0+OGqH1L5fqn7iWUbCqkpmk7 GFuDit5+EuJltoNgT5ty/1fEA50Mxtp/v1ldkbUFTlTPGk2Mm7m8myrOHwIj2Q== Date: Mon, 7 Oct 2024 10:31:14 +0200 From: Miquel Raynal To: Marcus Folkesson Cc: Krzysztof Kozlowski , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/2] dt-bindings: mtd: davinci: convert to yaml Message-ID: <20241007103114.1a63e3e2@xps-13> In-Reply-To: References: <20241006-ondie-v4-0-ff9b9fd9a81d@gmail.com> <20241006-ondie-v4-2-ff9b9fd9a81d@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Marcus, marcus.folkesson@gmail.com wrote on Mon, 7 Oct 2024 08:29:44 +0200: > On Mon, Oct 07, 2024 at 08:07:27AM +0200, Krzysztof Kozlowski wrote: > > On Sun, Oct 06, 2024 at 03:05:47PM +0200, Marcus Folkesson wrote: =20 > > > + ti,davinci-nand-use-bbt: > > > + type: boolean > > > + description: > > > + Use flash based bad block table support. OOB identifier is sav= ed in OOB > > > + area. > > > + deprecated: true > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - ti,davinci-chipselect > > > + > > > +additionalProperties: true =20 > >=20 > > That's a final device schema, this cannot be true. Why you are doing > > this entirely different than all other bindings? =20 >=20 > From my understanding, additionalProperties is to indicate that the > schema could contain properties that were not explicit listed here but > inherited from e.g. nand-controller.yaml. additionalProperties: true means there is no control over the properties allowed, so we generally don't want that (unless you're writing specific "generic" bindings, which is not the case here). You are describing a controller so here you should reference to nand-controller.yaml, but then prevent any property not defined in nand-controller.yaml from being used. In this case you probably want to try unevaluatedProperties: false, which means that any property not listed here or in the referenced schemas will be prohibited. Thanks, Miqu=C3=A8l