Re: [PATCH v4 0/6] refine argparse library

[Stephen Hemminger <stephen@networkplumber.org>]

On Mon, 18 Mar 2024 11:18:32 +0000
Chengwen Feng <fengchengwen@huawei.com> wrote:

> I found a couple of issues when I revisited the argparse_autotest
> output, so got this patchset.
> 
> Chengwen Feng (6):
>   argparse: refine error message
>   argparse: remove dead code
>   argparse: replace flag enum with marco
>   argparse: fix argument flags operate as uint32 type
>   test/argparse: refine testcases
>   argparse: fix doc don't display two hyphens
> 
> ---
> v4: address Thomas's comment on 4/6 commit:
> - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and
>   TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK.
> v3:
> - address Thomas's comment on 4/6 comit.
> - add commit: fix doc don't display two hyphens.
> v2: address David Marchand's comment:
> - replace flag enum with marco.
> - replace flag's hardcode with macro in test_argparse.c.
> 
>  app/test/test_argparse.c               | 65 +++++++++++---------
>  doc/guides/prog_guide/argparse_lib.rst | 47 +++++++-------
>  lib/argparse/rte_argparse.c            | 61 +++++++++---------
>  lib/argparse/rte_argparse.h            | 85 ++++++++++++--------------
>  4 files changed, 127 insertions(+), 131 deletions(-)
> 


The patch set looks good.
My only comment is the term 'refine' was confusing to me.
I guess you meant "improve", "clarify" or "reword" since most
of the changes are about changing the wording.

Series-Acked-by: Stephen Hemminger <stephen@networkplumber.org>