All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] ARM: dts: imx6qdl-tx6: Fix 'fixed-clock' description
Date: Tue, 8 Oct 2024 08:15:09 +0200	[thread overview]
Message-ID: <20241008081509.21df45da@ipc1.ka-ro> (raw)
In-Reply-To: <20241005125824.2037222-1-festevam@gmail.com>

Hi,

> From: Fabio Estevam <festevam@denx.de>
> 
> Per fixed-clock.yaml, it is not correct to pass unit address and
> reg to represent 'fixed-clock'.
> 
> Remove it to fix the following dt-schema warning:
> 
> clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/linux-arm-kernel/172808887941.121658.5039774358299826312.robh@kernel.org/
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Acked-by: Lothar Waßmann <LW@KARO-electronics.de>

> ---
>  arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
> index 5a194f4c0cb9..2fa37d1b16cc 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
> @@ -70,9 +70,8 @@ clocks {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		mclk: clock@0 {
> +		mclk: clock {
>  			compatible = "fixed-clock";
> -			reg = <0>;
>  			#clock-cells = <0>;
>  			clock-frequency = <26000000>;
>  		};

Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________


  reply	other threads:[~2024-10-08  6:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-05 12:58 [PATCH] ARM: dts: imx6qdl-tx6: Fix 'fixed-clock' description Fabio Estevam
2024-10-08  6:15 ` Lothar Waßmann [this message]
2024-10-21  9:38 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241008081509.21df45da@ipc1.ka-ro \
    --to=lw@karo-electronics.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.