From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 088051D9A43 for ; Tue, 8 Oct 2024 14:04:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728396287; cv=none; b=Yt3Ktazu0TfzMWH4NTV8G8fCH1FDZgMreGwN83VhSLaEa2lukLvZ6Y1B5driVIaxtJYMju4n86r43AUFDU/6pW13xL4jgxWlPhs54qiaKwJSDDeRwx4HXLFJXlGsPkkbEaT7jW8Tdc6o3uRuAy43tjP77yJJ9wS965DO6keCcYo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728396287; c=relaxed/simple; bh=TyjnE8Cl8BUiV44ccbi4F/Mx1PAYvm9DmLImjXSogU8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fI/zH04AY/wSKqSiduQiRqjanNKIktnl8/iEXp/m+eCRIrO0bD+H4ds75fumUDA/4Uuu5PX0q1AZVcmT5AyKKc3JsnyYpCYd5U8ZIINL2sScrMRFf9aGQDbpYbbTL1LFxOEbrPoXpgJToHGE62ehowByNwAM/7TaDaz3KP7eL20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20230601.gappssmtp.com header.i=@cmpxchg-org.20230601.gappssmtp.com header.b=vqbWoPWR; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20230601.gappssmtp.com header.i=@cmpxchg-org.20230601.gappssmtp.com header.b="vqbWoPWR" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7a99fd4ea26so461760085a.1 for ; Tue, 08 Oct 2024 07:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1728396283; x=1729001083; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TyjnE8Cl8BUiV44ccbi4F/Mx1PAYvm9DmLImjXSogU8=; b=vqbWoPWR1x8oLFDAN6Y7ugzbPWhFXxeqy+13p50wYDbJtEg6qq6MeXfcrnJb4qy7w/ p0zNR8x/SZPbDdrlqAJEkoMfni+zCPSiwya5sHHd7mWYd4RdT7EEpMb1yPYVoaQ0NrDc Tb+MLjwylCxuvySz9CNmjHm4dItSYaKpFKDGt4y0UIeRhDL9F2XJ0AoBEz8R0DfAV3VT B6oyRD6RSFlGje9fz4QCIADkBuma+FlYrhSw0crgC/pDwwDlQUjBmwCnRq4k11SeBOum hIu3cT/29a1Y5pHNdE1RGOj6ODHWguz2ewYpCDdkupv44SzaF0SRrKVz+/lhq2kC6dGb AY5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728396283; x=1729001083; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TyjnE8Cl8BUiV44ccbi4F/Mx1PAYvm9DmLImjXSogU8=; b=dLJdxKnqs1tj9eTCcaoTpy2mQhUPpsyRrCakH+bYraH7RbO3CdhmrUOyhun/rfrmDC Yu23UaUnHivKq2w5XMkN9N2djqjmdPor+Vr2mbjXrBeqNZRd2tmsmHzsEZD8/anWOFLC 6lRujtUswA1CMxlgLbzjNsS1hujhXNuIie/RrzAW4HjB0YBk92tkZSWQSPwLhcx6XrOA k3IVbKtTdc9k4U83hamDmC5ieTCuFc2rEihuxvnf2inhFAGoWgibmRR6Z9GvHfqjVQqk 1Bamb6uitljAeIUx73EW1WGMbz5TVbmLpunu0KGCjcjeBVTcRpyetu+8+YE7Gim9ABNb nvuA== X-Forwarded-Encrypted: i=1; AJvYcCWuasjS1R3TxDHSWjqAzyCImhnoUgN9j1e3DDGdE7ad9o6S35t+1R3rZ3X1g/F/10lCkupHDdIa@vger.kernel.org X-Gm-Message-State: AOJu0YzFMjqvX7VEArpuctxQ2ILexUjoyV7nejPd3t2HEJtXKtaSSNzj zJBVEzBxZpK0dA0owhbCpOYgRvkjhjETXNwzyImk5oLu85B3TWeb56BhoBjUJaE= X-Google-Smtp-Source: AGHT+IFnW2G/DfWAVwb6xF3THBSDW4i0rfBOz3jsospEhAW/qdZuxZtZPhcU4bN7LYLHEFGNDDmj9w== X-Received: by 2002:a05:620a:2993:b0:7a7:dd3a:a699 with SMTP id af79cd13be357-7ae6f421a2dmr2339888985a.11.1728396282545; Tue, 08 Oct 2024 07:04:42 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae7561e5d6sm356567985a.9.2024.10.08.07.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 07:04:41 -0700 (PDT) Date: Tue, 8 Oct 2024 10:04:37 -0400 From: Johannes Weiner To: Yafang Shao Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, surenb@google.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] sched, psi: Don't account irq time if sched_clock_irqtime is disabled Message-ID: <20241008140437.GA6937@cmpxchg.org> References: <20241008061951.3980-1-laoar.shao@gmail.com> <20241008061951.3980-4-laoar.shao@gmail.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241008061951.3980-4-laoar.shao@gmail.com> On Tue, Oct 08, 2024 at 02:19:50PM +0800, Yafang Shao wrote: > sched_clock_irqtime may be disabled due to the clock source, in which case > IRQ time should not be accounted. Let's add a conditional check to avoid > unnecessary logic. Makes sense. When disabled, irq_time_read() won't change over time, so there is nothing to account. We can save iterating the whole hierarchy on every tick and context switch. > Signed-off-by: Yafang Shao Acked-by: Johannes Weiner