From: Jakub Kicinski <kuba@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>,
<liuyonglong@huawei.com>, <fanghaiqing@huawei.com>,
<zhangkun09@huawei.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Eric Dumazet <edumazet@google.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2 1/2] page_pool: fix timing for checking and disabling napi_local
Date: Tue, 8 Oct 2024 17:40:22 -0700 [thread overview]
Message-ID: <20241008174022.0b6d92b9@kernel.org> (raw)
In-Reply-To: <20240925075707.3970187-2-linyunsheng@huawei.com>
On Wed, 25 Sep 2024 15:57:06 +0800 Yunsheng Lin wrote:
> Use rcu mechanism to avoid the above concurrent access problem.
>
> Note, the above was found during code reviewing on how to fix
> the problem in [1].
The driver must make sure NAPI cannot be running while
page_pool_destroy() is called. There's even an WARN()
checking this.. if you know what to look for.
next prev parent reply other threads:[~2024-10-09 0:40 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 7:57 [PATCH net v2 0/2] fix two bugs related to page_pool Yunsheng Lin
2024-09-25 7:57 ` [Intel-wired-lan] " Yunsheng Lin
2024-09-25 7:57 ` [PATCH net v2 1/2] page_pool: fix timing for checking and disabling napi_local Yunsheng Lin
2024-09-26 20:06 ` Joe Damato
2024-09-27 3:58 ` Yunsheng Lin
2024-10-01 11:30 ` Paolo Abeni
2024-10-02 1:52 ` Yunsheng Lin
2024-10-09 0:40 ` Jakub Kicinski [this message]
2024-10-09 3:33 ` Yunsheng Lin
2024-10-09 15:13 ` Jakub Kicinski
2024-10-10 9:14 ` Yunsheng Lin
2024-09-25 7:57 ` [PATCH net v2 2/2] page_pool: fix IOMMU crash when driver has already unbound Yunsheng Lin
2024-09-25 7:57 ` [Intel-wired-lan] " Yunsheng Lin
2024-09-26 18:15 ` Mina Almasry
2024-09-26 18:15 ` [Intel-wired-lan] " Mina Almasry
2024-09-27 3:57 ` Yunsheng Lin
2024-09-27 3:57 ` [Intel-wired-lan] " Yunsheng Lin
2024-09-27 5:54 ` Mina Almasry
2024-09-27 5:54 ` [Intel-wired-lan] " Mina Almasry
2024-09-27 7:25 ` Yunsheng Lin
2024-09-27 7:25 ` [Intel-wired-lan] " Yunsheng Lin
2024-09-27 9:21 ` Ilias Apalodimas
2024-09-27 9:21 ` [Intel-wired-lan] " Ilias Apalodimas
2024-09-27 9:49 ` Yunsheng Lin
2024-09-27 9:49 ` [Intel-wired-lan] " Yunsheng Lin
2024-09-27 9:58 ` Ilias Apalodimas
2024-09-27 9:58 ` [Intel-wired-lan] " Ilias Apalodimas
2024-09-27 11:29 ` Yunsheng Lin
2024-09-27 11:29 ` [Intel-wired-lan] " Yunsheng Lin
2024-09-28 7:34 ` Ilias Apalodimas
2024-09-28 7:34 ` [Intel-wired-lan] " Ilias Apalodimas
2024-09-29 2:44 ` Yunsheng Lin
2024-09-29 2:44 ` [Intel-wired-lan] " Yunsheng Lin
2024-09-30 8:09 ` Ilias Apalodimas
2024-09-30 8:09 ` [Intel-wired-lan] " Ilias Apalodimas
2024-09-30 8:38 ` Yunsheng Lin
2024-09-30 8:38 ` [Intel-wired-lan] " Yunsheng Lin
2024-10-01 13:32 ` Paolo Abeni
2024-10-01 13:32 ` [Intel-wired-lan] " Paolo Abeni
2024-10-02 2:34 ` Yunsheng Lin
2024-10-02 2:34 ` [Intel-wired-lan] " Yunsheng Lin
2024-10-02 7:37 ` Paolo Abeni
2024-10-02 7:37 ` [Intel-wired-lan] " Paolo Abeni
2024-10-02 8:23 ` Ilias Apalodimas
2024-10-02 8:23 ` [Intel-wired-lan] " Ilias Apalodimas
2024-10-05 12:38 ` Yunsheng Lin
2024-10-05 12:38 ` [Intel-wired-lan] " Yunsheng Lin
2024-10-02 6:46 ` Ilias Apalodimas
2024-10-02 6:46 ` [Intel-wired-lan] " Ilias Apalodimas
2024-10-02 6:51 ` Ilias Apalodimas
2024-10-02 6:51 ` [Intel-wired-lan] " Ilias Apalodimas
2024-09-25 13:31 ` [PATCH net v2 0/2] fix two bugs related to page_pool Yonglong Liu
2024-09-25 13:31 ` [Intel-wired-lan] " Yonglong Liu
2024-10-12 12:05 ` Yunsheng Lin
2024-10-12 12:05 ` [Intel-wired-lan] " Yunsheng Lin
2024-10-15 0:14 ` Jakub Kicinski
2024-10-15 0:14 ` [Intel-wired-lan] " Jakub Kicinski
2024-10-15 10:52 ` Yunsheng Lin
2024-10-15 10:52 ` [Intel-wired-lan] " Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008174022.0b6d92b9@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fanghaiqing@huawei.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhangkun09@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.