From: Frediano Ziglio <frediano.ziglio@cloud.com>
To: xen-devel@lists.xenproject.org
Cc: "Frediano Ziglio" <frediano.ziglio@cloud.com>,
"Daniel P. Smith" <dpsmith@apertussolutions.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v8 1/2] x86/boot: Align mbi2.c stack to 16 bytes
Date: Wed, 9 Oct 2024 09:04:38 +0100 [thread overview]
Message-ID: <20241009080439.2411730-2-frediano.ziglio@cloud.com> (raw)
In-Reply-To: <20241009080439.2411730-1-frediano.ziglio@cloud.com>
Doing previous testing with an Adler Lake Intel machine the following
patch (improving MBI structure checking) started to fail.
Excluding it makes the tests succeed however there was not apparent
reason (looking at the code) for the failure.
So I instrumented code to output the structure and tested code with
this extracted data with and without the following patch and results
were the same.
Compiled assembly code from lab was also fine beside not keeping
the 16-byte alignment for the stack.
Turning on stack alignment solve the problem on Adler Lake machine.
Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
---
xen/arch/x86/efi/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xen/arch/x86/efi/Makefile b/xen/arch/x86/efi/Makefile
index 7e2b5c07de..c2cad86856 100644
--- a/xen/arch/x86/efi/Makefile
+++ b/xen/arch/x86/efi/Makefile
@@ -11,6 +11,8 @@ $(obj)/boot.init.o: $(obj)/buildid.o
$(call cc-option-add,cflags-stack-boundary,CC,-mpreferred-stack-boundary=4)
$(addprefix $(obj)/,$(EFIOBJ-y)): CFLAGS_stack_boundary := $(cflags-stack-boundary)
+$(obj)/mbi2.o: CFLAGS_stack_boundary := $(cflags-stack-boundary)
+
obj-y := common-stub.o stub.o
obj-$(XEN_BUILD_EFI) := $(filter-out %.init.o,$(EFIOBJ-y))
obj-bin-$(XEN_BUILD_EFI) := $(filter %.init.o,$(EFIOBJ-y))
--
2.34.1
next prev parent reply other threads:[~2024-10-09 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 8:04 [PATCH v8 0/2] x86/boot: Improve MBI2 structure check (was: Reduce assembly code) Frediano Ziglio
2024-10-09 8:04 ` Frediano Ziglio [this message]
2024-10-09 8:20 ` [PATCH v8 1/2] x86/boot: Align mbi2.c stack to 16 bytes Jan Beulich
2024-10-09 10:15 ` Frediano Ziglio
2024-10-09 11:13 ` Jan Beulich
2024-10-10 8:34 ` Frediano Ziglio
2024-10-10 8:41 ` Jan Beulich
2024-10-09 8:04 ` [PATCH v8 2/2] x86/boot: Improve MBI2 structure check Frediano Ziglio
2024-10-09 8:22 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009080439.2411730-2-frediano.ziglio@cloud.com \
--to=frediano.ziglio@cloud.com \
--cc=andrew.cooper3@citrix.com \
--cc=dpsmith@apertussolutions.com \
--cc=jbeulich@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.