From: Greg KH <greg@kroah.com>
To: Xiangyu Chen <xiangyu.chen@windriver.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH v2 6.1/6.6] wifi: mac80211: Avoid address calculations via out of bounds array indexing
Date: Wed, 9 Oct 2024 15:34:26 +0200 [thread overview]
Message-ID: <2024100911-suffix-ranked-5323@gregkh> (raw)
In-Reply-To: <20241009081627.354405-2-xiangyu.chen@windriver.com>
On Wed, Oct 09, 2024 at 04:16:27PM +0800, Xiangyu Chen wrote:
> From: Kenton Groombridge <concord@gentoo.org>
>
> req->n_channels must be set before req->channels[] can be used.
>
> This patch fixes one of the issues encountered in [1].
>
> [ 83.964255] UBSAN: array-index-out-of-bounds in net/mac80211/scan.c:364:4
> [ 83.964258] index 0 is out of range for type 'struct ieee80211_channel *[]'
> [...]
> [ 83.964264] Call Trace:
> [ 83.964267] <TASK>
> [ 83.964269] dump_stack_lvl+0x3f/0xc0
> [ 83.964274] __ubsan_handle_out_of_bounds+0xec/0x110
> [ 83.964278] ieee80211_prep_hw_scan+0x2db/0x4b0
> [ 83.964281] __ieee80211_start_scan+0x601/0x990
> [ 83.964291] nl80211_trigger_scan+0x874/0x980
> [ 83.964295] genl_family_rcv_msg_doit+0xe8/0x160
> [ 83.964298] genl_rcv_msg+0x240/0x270
> [...]
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=218810
>
> Co-authored-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Kees Cook <kees@kernel.org>
> Signed-off-by: Kenton Groombridge <concord@gentoo.org>
> Link: https://msgid.link/20240605152218.236061-1-concord@gentoo.org
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> [Xiangyu: Modified to apply on 6.1.y and 6.6.y]
> Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
> ---
> V1 -> V2:
> add v6.6 support
No hint as to what the git id of this is in Linus's tree, so now
dropping :(
next prev parent reply other threads:[~2024-10-09 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 8:16 [PATCH 6.1] Drivers: hv: vmbus: Leak pages if set_memory_encrypted() fails Xiangyu Chen
2024-10-09 8:16 ` [PATCH v2 6.1/6.6] wifi: mac80211: Avoid address calculations via out of bounds array indexing Xiangyu Chen
2024-10-09 13:34 ` Greg KH [this message]
2024-10-09 13:33 ` [PATCH 6.1] Drivers: hv: vmbus: Leak pages if set_memory_encrypted() fails Greg KH
2024-10-10 2:53 ` Xiangyu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024100911-suffix-ranked-5323@gregkh \
--to=greg@kroah.com \
--cc=stable@vger.kernel.org \
--cc=xiangyu.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.