All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Donglin Peng <dolinux.peng@gmail.com>,
	mark.rutland@arm.com, mathieu.desnoyers@efficios.com,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 RESEND] function_graph: Support recording and printing the function return address
Date: Wed, 9 Oct 2024 13:19:20 -0400	[thread overview]
Message-ID: <20241009131920.2afaf15f@gandalf.local.home> (raw)
In-Reply-To: <20241010013222.3748287f165e9f874eda0f84@kernel.org>

On Thu, 10 Oct 2024 01:32:22 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> >From 8c2851452dd11a3a20ab22bd6bf8dd663c3c4b9c Mon Sep 17 00:00:00 2001  
> From: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
> Date: Thu, 10 Oct 2024 00:58:12 +0900
> Subject: [PATCH] tracing/fgraph: Simplify return address printing in function
>  graph tracer
> 
> Simplify return address printing in the function graph tracer by removing
> fgraph_extras. Since this feature is only used by the function graph
> tracer and we can check the flag directly in the function graph tracer,
> we can remove the fgraph_extras from the fgraph callback.
> 
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> ---
>  include/linux/ftrace.h               | 16 ++++------
>  kernel/trace/fgraph.c                | 45 ++++++++++++++++++----------
>  kernel/trace/ftrace.c                |  3 +-
>  kernel/trace/trace.h                 |  3 +-
>  kernel/trace/trace_functions_graph.c | 14 ++++-----
>  kernel/trace/trace_irqsoff.c         |  3 +-
>  kernel/trace/trace_sched_wakeup.c    |  3 +-
>  kernel/trace/trace_selftest.c        |  8 ++---
>  8 files changed, 48 insertions(+), 47 deletions(-)
> 

Hi Masami,

Care to send this as a real patch?

-- Steve

  reply	other threads:[~2024-10-09 17:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09  3:03 [PATCH v2 RESEND] function_graph: Support recording and printing the function return address Donglin Peng
2024-10-09 13:37 ` Steven Rostedt
2024-10-09 14:01   ` Donglin Peng
2024-10-09 14:45     ` Steven Rostedt
2024-10-09 15:03       ` Donglin Peng
2024-10-09 16:32 ` Masami Hiramatsu
2024-10-09 17:19   ` Steven Rostedt [this message]
2024-10-09 23:26     ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241009131920.2afaf15f@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=dolinux.peng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.