All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb+git@google.com>
To: linux-kernel@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
	Jason Andryuk <jason.andryuk@amd.com>,
	 Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	x86@kernel.org,  xen-devel@lists.xenproject.org
Subject: [PATCH v3 2/5] x86/pvh: Use correct size value in GDT descriptor
Date: Wed,  9 Oct 2024 18:04:41 +0200	[thread overview]
Message-ID: <20241009160438.3884381-9-ardb+git@google.com> (raw)
In-Reply-To: <20241009160438.3884381-7-ardb+git@google.com>

From: Ard Biesheuvel <ardb@kernel.org>

The limit field in a GDT descriptor is an inclusive bound, and therefore
one less than the size of the covered range.

Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
Tested-by: Jason Andryuk <jason.andryuk@amd.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 arch/x86/platform/pvh/head.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/pvh/head.S b/arch/x86/platform/pvh/head.S
index ce4fd8d33da4..5a196fb3ebd8 100644
--- a/arch/x86/platform/pvh/head.S
+++ b/arch/x86/platform/pvh/head.S
@@ -224,7 +224,7 @@ SYM_CODE_END(pvh_start_xen)
 	.section ".init.data","aw"
 	.balign 8
 SYM_DATA_START_LOCAL(gdt)
-	.word gdt_end - gdt_start
+	.word gdt_end - gdt_start - 1
 	.long _pa(gdt_start) /* x86-64 will overwrite if relocated. */
 	.word 0
 SYM_DATA_END(gdt)
-- 
2.47.0.rc0.187.ge670bccf7e-goog



  parent reply	other threads:[~2024-10-09 16:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 16:04 [PATCH v3 0/5] x86/xen: Drop absolute references from startup code Ard Biesheuvel
2024-10-09 16:04 ` [PATCH v3 1/5] x86/pvh: Call C code via the kernel virtual mapping Ard Biesheuvel
2024-10-09 16:04 ` Ard Biesheuvel [this message]
2024-10-09 16:04 ` [PATCH v3 3/5] x86/pvh: Omit needless clearing of phys_base Ard Biesheuvel
2024-10-09 16:04 ` [PATCH v3 4/5] x86/xen: Avoid relocatable quantities in Xen ELF notes Ard Biesheuvel
2024-10-09 17:16   ` Jason Andryuk
2024-10-09 16:04 ` [PATCH v3 5/5] x86/pvh: Avoid absolute symbol references in .head.text Ard Biesheuvel
2024-10-29 12:50 ` [PATCH v3 0/5] x86/xen: Drop absolute references from startup code Ard Biesheuvel
2024-10-29 12:54   ` Jürgen Groß
2024-10-30 13:48     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241009160438.3884381-9-ardb+git@google.com \
    --to=ardb+git@google.com \
    --cc=ardb@kernel.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jason.andryuk@amd.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.