From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
zlang@kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] generic/694: sync before sampling i_blocks
Date: Thu, 10 Oct 2024 08:59:52 +0200 [thread overview]
Message-ID: <20241010065952.GA6674@lst.de> (raw)
In-Reply-To: <20241009144817.GL21840@frogsfrogsfrogs>
On Wed, Oct 09, 2024 at 07:48:17AM -0700, Darrick J. Wong wrote:
> > +# make sure indirect block reservations and other temporary block reservations
> > +# are release before sampling i_blocks
>
> Nit: '...are released before...'
>
> > +sync
>
> Should this be more targeted since we only care about junk_file's
> i_blocks, not flushing everything in the system. e.g.
>
> sync $junk_file
I didn't even know sync took an optional file argument. But yes,
that should be fine.
prev parent reply other threads:[~2024-10-10 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 7:12 [PATCH] generic/694: sync before sampling i_blocks Christoph Hellwig
2024-10-09 14:48 ` Darrick J. Wong
2024-10-10 6:37 ` Zorro Lang
2024-10-10 6:59 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010065952.GA6674@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.