From: Andreas Kemnade <andreas@kemnade.info>
To: Roger Quadros <rogerq@kernel.org>
Cc: Kevin Hilman <khilman@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
linux-clk@vger.kernel.org, Lee Jones <lee@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 3/3] clk: twl: add TWL6030 support
Date: Thu, 10 Oct 2024 14:32:41 +0200 [thread overview]
Message-ID: <20241010143241.2f126066@akair> (raw)
In-Reply-To: <901ab11e-bfe3-487c-9867-53289c848792@kernel.org>
Am Thu, 10 Oct 2024 14:36:58 +0300
schrieb Roger Quadros <rogerq@kernel.org>:
> > + if (cinfo->type == TWL_TYPE_6032)
>
> Shouldn't this be done for TWL_TYPE_6030?
>
oops, that flipped through. Well, prepare() works seamlessly...
> > + ret = twlclk_write(cinfo, TWL_MODULE_PM_RECEIVER,
> > VREG_STATE,
> > + ALL_GRP <<
> > TWL6030_CFG_STATE_GRP_SHIFT |
> > + TWL6030_CFG_STATE_OFF);
> > + else> + ret = twlclk_write(cinfo,
> > TWL_MODULE_PM_RECEIVER, VREG_STATE,
> > + TWL6030_CFG_STATE_OFF);
> > +
prev parent reply other threads:[~2024-10-10 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 7:43 [PATCH v4 0/3] mfd: twl: Add clock for TWL6030 Andreas Kemnade
2024-10-10 7:43 ` [PATCH v4 1/3] mfd: twl-core: Add a clock subdevice for the TWL6030 Andreas Kemnade
2024-10-10 7:43 ` [PATCH v4 2/3] clk: twl: remove is_prepared Andreas Kemnade
2024-10-10 7:43 ` [PATCH v4 3/3] clk: twl: add TWL6030 support Andreas Kemnade
2024-10-10 11:36 ` Roger Quadros
2024-10-10 12:32 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010143241.2f126066@akair \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=khilman@baylibre.com \
--cc=lee@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rogerq@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.