From: Bjorn Helgaas <helgaas@kernel.org>
To: Tony Hutter <hutter2@llnl.gov>
Cc: Lukas Wunner <lukas@wunner.de>,
mariusz.tkaczyk@linux.intel.com, minyard@acm.org,
linux-pci@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] PCI: Introduce Cray ClusterStor E1000 NVMe slot LED driver
Date: Thu, 10 Oct 2024 14:29:54 -0500 [thread overview]
Message-ID: <20241010192954.GA574548@bhelgaas> (raw)
In-Reply-To: <5beda7c3-e5fa-4105-aefd-9d91fad6d967@llnl.gov>
On Thu, Oct 10, 2024 at 11:53:42AM -0700, Tony Hutter wrote:
> > I don't quite understand what the E1000 is and where this code
> > runs. Since you have a DMI check for DMI_PRODUCT_NAME "VSSEP1EC",
> > I assume E1000 is an attached storage controller, and this driver
> > is part of an embedded OS running inside the E1000 itself, *not*
> > on the system to which the E1000 is attached?
>
> You can think of an E1000 as a standard rack mount storage server
> with 24 NVMe slots. They are often used as Lustre servers. The DMI
> check makes sure the E1000 LED driver can only be loaded on E1000
> boards. The driver is running on the main system (where Lustre
> runs) rather than a embedded storage controller. The driver does
> communicate with a embedded controller via IPMI to control the LEDs
> though.
>
> I'm currently on baby bonding leave, but I'll try to implement your
> review comments into a version 3 patch once I get back into the
> office.
Congratulations! Hope your family is all doing well!
Bjorn
next prev parent reply other threads:[~2024-10-10 19:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 0:06 [PATCH v2] PCI: Introduce Cray ClusterStor E1000 NVMe slot LED driver Tony Hutter
2024-09-26 21:02 ` Bjorn Helgaas
2024-10-10 18:53 ` Tony Hutter
2024-10-10 19:29 ` Bjorn Helgaas [this message]
2025-10-30 9:30 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010192954.GA574548@bhelgaas \
--to=helgaas@kernel.org \
--cc=hutter2@llnl.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mariusz.tkaczyk@linux.intel.com \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.