From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Umang Jain <umang.jain@ideasonboard.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 4/5] staging: vchiq_core: Macros indentation fix
Date: Fri, 11 Oct 2024 06:36:09 +0200 [thread overview]
Message-ID: <2024101103-dizziness-occultist-b6ed@gregkh> (raw)
In-Reply-To: <890c234b-6d68-4a43-8bea-208e5d1a115c@gmx.net>
On Thu, Oct 10, 2024 at 06:50:24PM +0200, Stefan Wahren wrote:
> Hi Umang,
>
> Am 10.10.24 um 12:22 schrieb Umang Jain:
> > Make sure that MAKE_* macros fit within 80 columns instead of spanning
> > in a single line.
> honestly i'm not a fan of this change, because it just silence
> checkpatch but doesn't improve readability.
Agreed, this shouldn't be needed.
next prev parent reply other threads:[~2024-10-11 4:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 10:22 [PATCH 0/5] staging: vchiq_core: Improve indentation Umang Jain
2024-10-10 10:22 ` [PATCH 1/5] staging: vchiq_core: Fix white space indentation error Umang Jain
2024-10-10 16:54 ` Stefan Wahren
2024-10-10 10:22 ` [PATCH 2/5] staging: vchiq_core: Indent static_assert on single line Umang Jain
2024-10-10 16:55 ` Stefan Wahren
2024-10-10 10:22 ` [PATCH 3/5] staging: vchiq_core: Reflow long lines to 80 columns Umang Jain
2024-10-11 4:36 ` Greg Kroah-Hartman
2024-10-10 10:22 ` [PATCH 4/5] staging: vchiq_core: Macros indentation fix Umang Jain
2024-10-10 16:50 ` Stefan Wahren
2024-10-11 4:36 ` Greg Kroah-Hartman [this message]
2024-10-10 10:22 ` [PATCH 5/5] staging: vchiq_core: Locally cache cache_line_size information Umang Jain
2024-10-10 16:52 ` Stefan Wahren
2024-10-11 4:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024101103-dizziness-occultist-b6ed@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@linaro.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=umang.jain@ideasonboard.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.