Re: [RFC PATCH] mmc: suspend MMC also when unbinding

[kernel test robot <lkp@intel.com>]

Hi Wolfram,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.12-rc2 next-20241010]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Wolfram-Sang/mmc-suspend-MMC-also-when-unbinding/20241007-173705
base:   linus/master
patch link:    https://lore.kernel.org/r/20241007093447.33084-2-wsa%2Brenesas%40sang-engineering.com
patch subject: [RFC PATCH] mmc: suspend MMC also when unbinding
config: i386-randconfig-141-20241010 (https://download.01.org/0day-ci/archive/20241011/202410110517.E2SBXURn-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410110517.E2SBXURn-lkp@intel.com/

smatch warnings:
drivers/mmc/core/mmc.c:2124 _mmc_suspend() warn: inconsistent indenting

vim +2124 drivers/mmc/core/mmc.c

  2114	
  2115	static int _mmc_suspend(struct mmc_host *host, enum mmc_pm_reason reason)
  2116	{
  2117		int err = 0;
  2118		unsigned int notify_type = reason == MMC_PM_REASON_SUSPEND ?
  2119					   EXT_CSD_POWER_OFF_SHORT : EXT_CSD_POWER_OFF_LONG;
  2120		bool can_pwr_cycle_now = (host->caps2 & MMC_CAP2_FULL_PWR_CYCLE) ||
  2121					  ((host->caps2 & MMC_CAP2_FULL_PWR_CYCLE_IN_SUSPEND) &&
  2122					    reason == MMC_PM_REASON_SUSPEND);
  2123	
> 2124	pr_info("%s: suspend reason %d, can pwr cycle %d\n", mmc_hostname(host), reason, can_pwr_cycle_now);
  2125	
  2126		mmc_claim_host(host);
  2127	
  2128		if (mmc_card_suspended(host->card))
  2129			goto out;
  2130	
  2131		err = _mmc_flush_cache(host);
  2132		if (err)
  2133			goto out;
  2134	
  2135		/* Notify if pwr_cycle is possible or power gets cut because of shutdown */
  2136		if (mmc_can_poweroff_notify(host->card) &&
  2137		    (reason == MMC_PM_REASON_SHUTDOWN || can_pwr_cycle_now))
  2138			err = mmc_poweroff_notify(host->card, notify_type);
  2139		else if (mmc_can_sleep(host->card))
  2140			err = mmc_sleep(host);
  2141		else if (!mmc_host_is_spi(host))
  2142			err = mmc_deselect_cards(host);
  2143	
  2144		if (!err) {
  2145			mmc_power_off(host);
  2146			mmc_card_set_suspended(host->card);
  2147		}
  2148	out:
  2149		mmc_release_host(host);
  2150		return err;
  2151	}
  2152	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki