All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Abhash Jha <abhashkumarjha123@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	<gregkh@linuxfoundation.org>
Subject: Re: linux-next: build failure after merge of the iio tree
Date: Fri, 11 Oct 2024 10:42:32 +0100	[thread overview]
Message-ID: <20241011104232.000042a9@Huawei.com> (raw)
In-Reply-To: <20241011154241.511878bd@canb.auug.org.au>

On Fri, 11 Oct 2024 15:42:41 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
>
Thanks Stephen,

I'll call these out (I think we have 3 of them now) when I send Greg a pull request as
probably best place to tidy this up is when merging into char-misc which has
merged rc2 with Al's patch.

Greg, let me know if you'd rather I handled these in the iio tree
(probably a merge of rc2 as I'd rather not rebase)

Jonathan


> After merging the iio tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/iio/dac/ad5770r.c:20:10: fatal error: asm/unaligned.h: No such file or directory
>    20 | #include <asm/unaligned.h>
>       |          ^~~~~~~~~~~~~~~~~
> drivers/iio/adc/max1363.c:37:10: fatal error: asm/unaligned.h: No such file or directory
>    37 | #include <asm/unaligned.h>
>       |          ^~~~~~~~~~~~~~~~~
> 
> Caused by commits
> 
>   c2c4826cfa46 ("iio: adc: max1363: Convert to get_unaligned_be16")
>   0f87813bc338 ("iio: dac: ad5770r: Convert to get_unaligned_le16")
> 
> interacting with commit
> 
>   5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h")
> 
> from Linus' tree (in v6.12-rc2).
> 
> I have applied the following merge fix patch.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 11 Oct 2024 15:35:57 +1100
> Subject: [PATCH] fix up for asm/unaligned inclusions in ad5770r.c and max1363.c
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/iio/adc/max1363.c | 2 +-
>  drivers/iio/dac/ad5770r.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index d59cd638db96..d065b1ade95a 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -34,7 +34,7 @@
>  #include <linux/iio/trigger_consumer.h>
>  #include <linux/iio/triggered_buffer.h>
>  
> -#include <asm/unaligned.h>
> +#include <linux/unaligned.h>
>  
>  #define MAX1363_SETUP_BYTE(a) ((a) | 0x80)
>  
> diff --git a/drivers/iio/dac/ad5770r.c b/drivers/iio/dac/ad5770r.c
> index 12c98f3e62a5..7d7f5110d66a 100644
> --- a/drivers/iio/dac/ad5770r.c
> +++ b/drivers/iio/dac/ad5770r.c
> @@ -17,7 +17,7 @@
>  #include <linux/regmap.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/spi/spi.h>
> -#include <asm/unaligned.h>
> +#include <linux/unaligned.h>
>  
>  #define ADI_SPI_IF_CONFIG_A		0x00
>  #define ADI_SPI_IF_CONFIG_B		0x01


  reply	other threads:[~2024-10-11  9:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11  4:42 linux-next: build failure after merge of the iio tree Stephen Rothwell
2024-10-11  9:42 ` Jonathan Cameron [this message]
2024-10-11 12:09   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2026-01-19 19:20 Mark Brown
2026-01-20  9:47 ` Jonathan Cameron
2024-10-08  4:41 Stephen Rothwell
2023-02-09  3:38 Stephen Rothwell
2023-02-09 10:20 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241011104232.000042a9@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=abhashkumarjha123@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.