All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Magnus Damm <magnus.damm@gmail.com>,
	qemu-arm@nongnu.org, Thomas Huth <thuth@redhat.com>
Subject: [PATCH 16/17] Revert "hw/sh4/r2d: Realize IDE controller before accessing it"
Date: Fri, 11 Oct 2024 15:19:33 +0200	[thread overview]
Message-ID: <20241011131937.377223-17-thuth@redhat.com> (raw)
In-Reply-To: <20241011131937.377223-1-thuth@redhat.com>

This reverts commit 3c5f86a22686ef475a8259c0d8ee714f61c770c9.

Changing the order here caused a regression with the "tuxrun"
kernels (from https://storage.tuxboot.com/20230331/) - ATA commands
fail with a "ata1: lost interrupt (Status 0x58)" message.
Apparently we need to wire the interrupt here first before
realizing the device, so revert the change to the original
behavior.

Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/sh4/r2d.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c
index e5ac6751bd..7eecd79fcc 100644
--- a/hw/sh4/r2d.c
+++ b/hw/sh4/r2d.c
@@ -286,9 +286,9 @@ static void r2d_init(MachineState *machine)
     dinfo = drive_get(IF_IDE, 0, 0);
     dev = qdev_new("mmio-ide");
     busdev = SYS_BUS_DEVICE(dev);
+    sysbus_connect_irq(busdev, 0, irq[CF_IDE]);
     qdev_prop_set_uint32(dev, "shift", 1);
     sysbus_realize_and_unref(busdev, &error_fatal);
-    sysbus_connect_irq(busdev, 0, irq[CF_IDE]);
     sysbus_mmio_map(busdev, 0, 0x14001000);
     sysbus_mmio_map(busdev, 1, 0x1400080c);
     mmio_ide_init_drives(dev, dinfo, NULL);
-- 
2.46.1

  parent reply	other threads:[~2024-10-11 13:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 13:19 [PATCH 00/17] Convert the Avocado tuxrun tests into new functional tests Thomas Huth
2024-10-11 13:19 ` [PATCH 01/17] tests/functional: Add a base class for the TuxRun tests Thomas Huth
2024-10-11 13:19 ` [PATCH 02/17] tests/functional: Convert the Avocado ppc64 tuxrun tests Thomas Huth
2024-10-11 13:19 ` [PATCH 03/17] tests/functional: Convert the Avocado aarch64 " Thomas Huth
2024-10-11 13:19 ` [PATCH 04/17] tests/functional: Convert the Avocado sparc64 tuxrun test Thomas Huth
2024-10-11 13:19 ` [PATCH 05/17] tests/functional: Convert the Avocado s390x " Thomas Huth
2024-10-11 13:19 ` [PATCH 06/17] tests/functional: Convert the Avocado arm tuxrun tests Thomas Huth
2024-10-11 13:19 ` [PATCH 07/17] tests/functional: Convert the Avocado riscv32 " Thomas Huth
2024-10-11 13:19 ` [PATCH 08/17] tests/functional: Convert the Avocado riscv64 " Thomas Huth
2024-10-11 13:19 ` [PATCH 09/17] tests/functional: Convert the Avocado i386 tuxrun test Thomas Huth
2024-10-11 13:19 ` [PATCH 10/17] tests/functional: Convert the Avocado x86_64 " Thomas Huth
2024-10-11 13:19 ` [PATCH 11/17] tests/functional: Convert the Avocado mips " Thomas Huth
2024-10-11 13:19 ` [PATCH 12/17] tests/functional: Convert the Avocado mipsel " Thomas Huth
2024-10-11 13:19 ` [PATCH 13/17] tests/functional: Convert the Avocado mips64 " Thomas Huth
2024-10-11 13:19 ` [PATCH 14/17] tests/functional: Convert the Avocado mips64el " Thomas Huth
2024-10-11 13:19 ` [PATCH 15/17] tests/functional: Convert the Avocado ppc32 " Thomas Huth
2024-10-11 13:19 ` Thomas Huth [this message]
2024-10-11 22:52   ` [PATCH 16/17] Revert "hw/sh4/r2d: Realize IDE controller before accessing it" Philippe Mathieu-Daudé
2024-10-11 13:19 ` [PATCH 17/17] tests/functional: Convert the Avocado sh4 tuxrun test Thomas Huth
2024-10-13 15:27 ` [PATCH 00/17] Convert the Avocado tuxrun tests into new functional tests Alex Bennée
2024-10-14  6:12   ` Thomas Huth
2024-10-14 10:13     ` Daniel P. Berrangé
2024-10-21  6:01 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241011131937.377223-17-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=linux@roeck-us.net \
    --cc=magnus.damm@gmail.com \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.