Re: [PATCH v3 2/3] dt-bindings: clock: Add i.MX91 clock definition

[Rob Herring <robh@kernel.org>]

On Fri, Oct 11, 2024 at 04:40:35PM +0200, Krzysztof Kozlowski wrote:
> On Thu, Oct 10, 2024 at 09:57:35PM -0700, Pengfei Li wrote:
> > i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93.
> > Add i.MX91 related clock definition.
> > 
> > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
> > Reviewed-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  include/dt-bindings/clock/imx93-clock.h | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h
> > index 787c9e74dc96..6c685067288b 100644
> > --- a/include/dt-bindings/clock/imx93-clock.h
> > +++ b/include/dt-bindings/clock/imx93-clock.h
> > @@ -204,6 +204,10 @@
> >  #define IMX93_CLK_A55_SEL		199
> >  #define IMX93_CLK_A55_CORE		200
> >  #define IMX93_CLK_PDM_IPG		201
> > -#define IMX93_CLK_END			202
> 
> This is supposed to be separate patch, because you are removing
> something from ABI.

But "end" defines are not part of the ABI.

> 
> If your maintainer NAKed it, then do not sneak it some other way. Sort
> the problem with maintainer or entire patchset cannot enter.
> 
> Best regards,
> Krzysztof
>