From: Greg KH <gregkh@linuxfoundation.org>
To: Li Li <dualli@chromium.org>
Cc: dualli@google.com, corbet@lwn.net, arve@android.com,
tkjos@android.com, maco@android.com, joel@joelfernandes.org,
brauner@kernel.org, cmllamas@google.com, surenb@google.com,
arnd@arndb.de, masahiroy@kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
hridya@google.com, smoreland@google.com, kernel-team@android.com
Subject: Re: [PATCH v2 1/1] binder: report txn errors via generic netlink
Date: Fri, 11 Oct 2024 08:51:04 +0200 [thread overview]
Message-ID: <2024101149-steadfast-skater-c567@gregkh> (raw)
In-Reply-To: <20241011064427.1565287-2-dualli@chromium.org>
On Thu, Oct 10, 2024 at 11:44:27PM -0700, Li Li wrote:
> From: Li Li <dualli@google.com>
>
> Frozen tasks can't process binder transactions, so sync binder
> transactions will fail with BR_FROZEN_REPLY and async binder
> transactions will be queued in the kernel async binder buffer.
> As these queued async transactions accumulates over time, the async
> buffer will eventually be running out, denying all new transactions
> after that with BR_FAILED_REPLY.
>
> In addition to the above cases, different kinds of binder error codes
> might be returned to the sender. However, the core Linux, or Android,
> system administration process never knows what's actually happening.
>
> This patch introduces the Linux generic netlink messages into the binder
> driver so that the Linux/Android system administration process can
> listen to important events and take corresponding actions, like stopping
> a broken app from attacking the OS by sending huge amount of spamming
> binder transactions.
>
> To prevent making the already bloated binder.c even bigger, a new source
> file binder_genl.c is created to host those generic netlink code.
>
> Signed-off-by: Li Li <dualli@google.com>
> ---
> Documentation/admin-guide/binder_genl.rst | 69 ++++++
You add a file but not to the documentation build? Did you test-build
the documentation to see where it shows up at?
thanks,
greg k-h
next prev parent reply other threads:[~2024-10-11 6:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 6:44 [PATCH v2 0/1] binder: report txn errors via generic netlink (genl) Li Li
2024-10-11 6:44 ` [PATCH v2 1/1] binder: report txn errors via generic netlink Li Li
2024-10-11 6:51 ` Greg KH [this message]
2024-10-11 7:42 ` Li Li
2024-10-11 16:09 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024101149-steadfast-skater-c567@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=corbet@lwn.net \
--cc=devel@driverdev.osuosl.org \
--cc=dualli@chromium.org \
--cc=dualli@google.com \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=smoreland@google.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.