From: Simon Horman <horms@kernel.org>
To: linux@treblig.org
Cc: idryomov@gmail.com, xiubli@redhat.com,
ceph-devel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libceph: Remove crush deadcode
Date: Sat, 12 Oct 2024 14:32:23 +0100 [thread overview]
Message-ID: <20241012133223.GJ77519@kernel.org> (raw)
In-Reply-To: <20241011224736.236863-1-linux@treblig.org>
On Fri, Oct 11, 2024 at 11:47:36PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> crush_bucket_alg_name(), crush_get_bucket_item_weight(), crush_hash32(),
> and crush_hash32_5() were added by commit
> 5ecc0a0f8128 ("ceph: CRUSH mapping algorithm")
> in 2009 but never used.
>
> crush_hash_name() was added a little later by commit
> fb690390e305 ("ceph: make CRUSH hash function a bucket property")
> and also not used.
>
> Remove them.
>
> They called a couple of static functions crush_hash32_rjenkins1()
> and crush_hash32_rjenkins1_5() which are now unused.
>
> Also remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-12 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 22:47 [PATCH] libceph: Remove crush deadcode linux
2024-10-12 13:32 ` Simon Horman [this message]
2024-10-27 20:40 ` Ilya Dryomov
2024-10-27 21:00 ` Dr. David Alan Gilbert
2024-10-27 21:47 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241012133223.GJ77519@kernel.org \
--to=horms@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=netdev@vger.kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.