From: Stephen Hemminger <stephen@networkplumber.org>
To: <vignesh.purushotham.srinivas@ericsson.com>
Cc: <linville@tuxdriver.com>, <dev@dpdk.org>
Subject: Re: [PATCH] net/af_packet: add explicit flush for Tx
Date: Sat, 12 Oct 2024 18:15:48 -0700 [thread overview]
Message-ID: <20241012181548.227f66a2@hermes.local> (raw)
In-Reply-To: <20240815115653.603552-1-vignesh.purushotham.srinivas@ericsson.com>
On Thu, 15 Aug 2024 13:56:53 +0200
<vignesh.purushotham.srinivas@ericsson.com> wrote:
> From: Vignesh PS <vignesh.purushotham.srinivas@ericsson.com>
>
> af_packet PMD uses system calls to transmit packets. Separate the
> transmit function into two different calls so its possible to avoid
> syscalls during transmit.
>
> Signed-off-by: Vignesh PS <vignesh.purushotham.srinivas@ericsson.com>
The way to avoid syscalls is for the application to call tx_burst with
more than one packet. This patch makes the AF_PACKET PMD behave different
than other PMD's; that is a bad idea.
If this optimization is really necessary it should be setup and tuned
via existing eth_tx_conf like tx_threshold.
The wording of the description is awkward and not written in user focused
imperative language; also has spelling errors.
prev parent reply other threads:[~2024-10-13 1:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 11:56 [PATCH] net/af_packet: add explicit flush for Tx vignesh.purushotham.srinivas
2024-10-13 1:15 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241012181548.227f66a2@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
--cc=vignesh.purushotham.srinivas@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.