From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15C9A12C7F9 for ; Sun, 13 Oct 2024 18:55:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728845734; cv=none; b=INyam92wgWoQZ6QrFeOhDPLRnaQLeMvQT7xt57rsT+xkoG7lQ1/IM/07b5g+8fL+UmT96M6dvsSHkMZrj+7ejxBeYOwCCIQm3oGBrsEq+22bB5dLXFr5eJRoj/aCckAlUHnxtuN9KrkXplIR+5Y+DdZqQd8QcZ2CMbdoozVAWmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728845734; c=relaxed/simple; bh=tnoLGACvyZlv6R4EDQ15M1x1Pd9+UnPAmSvMFk51BbE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gww8GtRaqVex3EUJSG3W6quNJpp8efOnn+4bP2crTB9HWnTLIkbnmYCpjqyA5QlroErc3CqRqRqxoopCEdquKmgl7HpQpFMFei7EXJx999Nw9vKjGLorrmmiQfZFGtxE0kqwY7upNjtPOJo2kP1ufk7Nmh8sieS0x9q5l/3umV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WNkqLEan; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WNkqLEan" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a993a6348e0so289221166b.1 for ; Sun, 13 Oct 2024 11:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728845731; x=1729450531; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=D+/sR2kjz9V+zWn0d2wDxRH2CVHlBDFu10ji8AcnuMk=; b=WNkqLEank3peG4v5O8eLYWFuuA2mzMuP70xxavjjMu0uN/Aa0H/FtORl/dvaM+uZ1L lJx1An/QybNaLJkJUPYaI4LKsfvXKw2/VcSgUyoh5S8o7DO3qxRW6yqTDEF9Bgqacd3D NqIAVQJ3UTWWfdHgQotJb/bMWyururmmoAtoefktpU4bll2oAz2lff1u8+9K2A0c5vXt bRsCelQeAGDRIx89HAnpQI+n9Uuz1wOltQB4Br53Ph1n8PyE1Ji7WpJMKEK/XeU5n1Zf +wz/WP0/S2ImtpMdzqWZdwX9iJ3uhlYXC4C4fTt1TRBIKws+UizV0lOBaUmCZwjgPUOD A7fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728845731; x=1729450531; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D+/sR2kjz9V+zWn0d2wDxRH2CVHlBDFu10ji8AcnuMk=; b=mtekQSlk7RDVGbWG882be0yFTejbKbpEfDv8ZvDXEz3drIZjfCcZPhasldntob2Np4 u1ZGQyQTHGYpEJA0vO5LFvRIwA0tvlh0l4zHUsfkI4zM1unimP3Y5lkKFetMnaoi4iso PM2OTQx5cEqNVRuVCW1HzQjGkW83YasAoTvTV2w6DA/TN36lR2xsZuPGO0kDrzb4LvVj IpBdQH6zg6tA1BrRxXWOTTQrOq39z6yVTYlgOTmPJV0XlZgOzOAZj+srFjEgyWMi5RR3 /il3R916TQMGcucYCzdbtkeV0wsaGrpBO9wS+SPm7/i1sAnW+OLzJ1PWP24dBTdy3+O+ I2xQ== X-Forwarded-Encrypted: i=1; AJvYcCWWgYip05ACBknGxsOtdROLdkLEMSajDDQFUoC97VMrINPIsO+09Jt/7Sk350D+bZYLUYFJ0dI=@lists.linux.dev X-Gm-Message-State: AOJu0YxSAb32er1E7/dB/n1YsCe9ieRSg7+k2M1vH3lq0Vmini0HaLzc SNabr9m+XnEGA0RDDlkdtOnLKoVwtmmB20ce0X62CqEUuvHYSjFE X-Google-Smtp-Source: AGHT+IFUs+QjM43yj3nlR0ziuQLWkrMusL86D6FHgNlbZ4Yj4coPCVb+b+uweHJZ0+t4PyPXDgXOQg== X-Received: by 2002:a05:6402:3510:b0:5c9:5aac:c622 with SMTP id 4fb4d7f45d1cf-5c95ac09918mr12547222a12.5.1728845731151; Sun, 13 Oct 2024 11:55:31 -0700 (PDT) Received: from corebook.localdomain (2001-1c00-020d-1300-1b1c-4449-176a-89ea.cable.dynamic.v6.ziggo.nl. [2001:1c00:20d:1300:1b1c:4449:176a:89ea]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a12d384b9sm13500866b.172.2024.10.13.11.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Oct 2024 11:55:30 -0700 (PDT) From: Eric Woudstra To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Pablo Neira Ayuso , Jozsef Kadlecsik , Roopa Prabhu , Nikolay Aleksandrov , Matthias Brugger , AngeloGioacchino Del Regno , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , "Frank Wunderlich" , Daniel Golle , Eric Woudstra Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH RFC v1 net-next 00/12] bridge-fastpath and related improvements Date: Sun, 13 Oct 2024 20:54:56 +0200 Message-ID: <20241013185509.4430-1-ericwouds@gmail.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: bridge@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patchset makes it possible to set up a (hardware offloaded) fastpath for bridged interfaces. To set up the fastpath with offloading, add this extra flowtable: table bridge filter { flowtable fb { hook ingress priority filter devices = { lan0, lan1, lan2, lan3, lan4, wlan0, wlan1 } flags offload } chain forward { type filter hook forward priority filter; policy accept; ct state established flow add @fb } } Creating a separate fastpath for bridges. forward fastpath bypass .----------------------------------------. / \ | IP - forwarding | | / \ v | / wan ... | / | | | | | brlan.1 | | | +-------------------------------+ | | vlan 1 | | | | | | brlan (vlan-filtering) | | +---------------+ | | | DSA-SWITCH | | | | | vlan 1 | | | | to | | | vlan 1 | untagged | | +---------------+---------------+ . / \ ------>lan0 wlan1 . ^ ^ . | | . \_________________/ . bridge fastpath bypass . ^ vlan 1 tagged packets To have the ability to handle xmit direct with outgoing encaps in the bridge fastpass bypass, we need to be able to handle them without going through vlan/pppoe devices. So I've applied, amended and squashed wenxu's patchset. This patch also makes it possible to egress from vlan-filtering brlan to lan0 with vlan tagged packets, if the bridge master port is doing the vlan tagging, instead of the vlan-device. Without this patch, this is not possible in the bridge-fastpath and also not in the forward-fastpath, as seen in the figure above. There are also some more fixes for filling in the forward path. These fixes also apply to for the forward-fastpath. They include handling DEV_PATH_MTK_WDMA in nft_dev_path_info() and avoiding DEV_PATH_BR_VLAN_UNTAG_HW for bridges with ports that use dsa. Conntrack bridge only tracks untagged and 802.1q. To make the bridge fastpath experience more similar to the forward fastpath experience, I've added double vlan, pppoe and pppoe-in-q tagged packets to bridge conntrack and to bridge filter chain. Eric Woudstra (12): netfilter: nf_flow_table_offload: Add nf_flow_encap_push() for xmit direct netfilter: bridge: Add conntrack double vlan and pppoe netfilter: nft_chain_filter: Add bridge double vlan and pppoe bridge: br_vlan_fill_forward_path_pvid: Add port to port bridge: br_fill_forward_path add port to port net: core: dev: Add dev_fill_bridge_path() netfilter :nf_flow_table_offload: Add nf_flow_rule_bridge() netfilter: nf_flow_table_inet: Add nf_flowtable_type flowtable_bridge netfilter: nft_flow_offload: Add NFPROTO_BRIDGE to validate netfilter: nft_flow_offload: Add DEV_PATH_MTK_WDMA to nft_dev_path_info() bridge: br_vlan_fill_forward_path_mode no _UNTAG_HW for dsa netfilter: nft_flow_offload: Add bridgeflow to nft_flow_offload_eval() include/linux/netdevice.h | 2 + include/net/netfilter/nf_flow_table.h | 3 + net/bridge/br_device.c | 20 ++- net/bridge/br_private.h | 2 + net/bridge/br_vlan.c | 24 +++- net/bridge/netfilter/nf_conntrack_bridge.c | 86 ++++++++++-- net/core/dev.c | 77 +++++++++-- net/netfilter/nf_flow_table_inet.c | 13 ++ net/netfilter/nf_flow_table_ip.c | 96 ++++++++++++- net/netfilter/nf_flow_table_offload.c | 13 ++ net/netfilter/nft_chain_filter.c | 20 ++- net/netfilter/nft_flow_offload.c | 154 +++++++++++++++++++-- 12 files changed, 463 insertions(+), 47 deletions(-) -- 2.45.2