From: Greg KH <gregkh@linuxfoundation.org>
To: Akshay Gupta <akshay.gupta@amd.com>
Cc: linux-hwmon@vger.kernel.org, inux-kernel@vger.kernel.org,
linux@roeck-us.net, arnd@arndb.de,
naveenkrishna.chatradhi@amd.com
Subject: Re: [PATCH v4 4/9] misc: amd-sbi: Add support for AMD_SBI IOCTL
Date: Sun, 13 Oct 2024 17:22:00 +0200 [thread overview]
Message-ID: <2024101329-suitor-humpback-21ca@gregkh> (raw)
In-Reply-To: <20240912070810.1644621-5-akshay.gupta@amd.com>
On Thu, Sep 12, 2024 at 07:08:05AM +0000, Akshay Gupta wrote:
> + switch (msg.cmd) {
> + case 0 ... 0x999:
> + /* Mailbox protocol */
> + ret = rmi_mailbox_xfer(data, &msg);
> + break;
> + default:
> + pr_err("Command:0x%x not recognized\n", msg.cmd);
You now just allowed userspace to spam the kernel logs for no good
reason :(
Also, always use dev_*() calls in a driver, not pr_*() ones, as then you
will know exactly what driver/device is sending out the message.
> + break;
And you returned the wrong error code if this happens :(
greg k-h
next prev parent reply other threads:[~2024-10-13 15:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 7:08 [PATCH v4 0/9] misc: Add AMD side band interface(SBI) functionality Akshay Gupta
2024-09-12 7:08 ` [PATCH v4 1/9] hwmon/misc: amd-sbi: Move core sbrmi from hwmon to misc Akshay Gupta
2024-09-12 7:08 ` [PATCH v4 2/9] misc: amd-sbi: Use regmap subsystem Akshay Gupta
2024-09-12 7:08 ` [PATCH v4 3/9] misc: amd-sbi: Optimize the wait condition for mailbox command completion Akshay Gupta
2024-09-12 7:08 ` [PATCH v4 4/9] misc: amd-sbi: Add support for AMD_SBI IOCTL Akshay Gupta
2024-10-13 15:18 ` Greg KH
2024-10-14 11:26 ` Gupta, Akshay
2024-10-13 15:22 ` Greg KH [this message]
2024-10-15 9:04 ` Gupta, Akshay
2024-09-12 7:08 ` [PATCH v4 5/9] misc: amd-sbi: Add support for mailbox error codes Akshay Gupta
2024-10-13 15:19 ` Greg KH
2024-10-15 9:12 ` Gupta, Akshay
2024-10-15 10:04 ` Greg KH
2024-10-18 9:23 ` Gupta, Akshay
2024-10-18 9:35 ` Greg KH
2024-10-21 16:07 ` Gupta, Akshay
2024-09-12 7:08 ` [PATCH v4 6/9] misc: amd-sbi: Add support for CPUID protocol Akshay Gupta
2024-09-12 7:08 ` [PATCH v4 7/9] misc: amd-sbi: Add support for MCA register protocol Akshay Gupta
2024-09-12 7:08 ` [PATCH v4 8/9] misc: amd-sbi: Add supoort for register xfer Akshay Gupta
2024-09-12 7:08 ` [PATCH v4 9/9] misc: amd-sbi: Add document for AMD SB IOCTL description Akshay Gupta
2024-09-20 6:45 ` [PATCH v4 0/9] misc: Add AMD side band interface(SBI) functionality Gupta, Akshay
2024-09-21 9:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024101329-suitor-humpback-21ca@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akshay.gupta@amd.com \
--cc=arnd@arndb.de \
--cc=inux-kernel@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naveenkrishna.chatradhi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.