All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, "Jason Wang" <jasowang@redhat.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	virtualization@lists.linux.dev,
	"Darren Kenny" <darren.kenny@oracle.com>,
	"Si-Wei Liu" <si-wei.liu@oracle.com>
Subject: Re: [PATCH 0/5] virtio_net: enable premapped mode by default
Date: Mon, 14 Oct 2024 00:57:41 -0400	[thread overview]
Message-ID: <20241014005529-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20241014031234.7659-1-xuanzhuo@linux.alibaba.com>

On Mon, Oct 14, 2024 at 11:12:29AM +0800, Xuan Zhuo wrote:
> In the last linux version, we disabled this feature to fix the
> regress[1].
> 
> The patch set is try to fix the problem and re-enable it.
> 
> More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com
> 
> Thanks.
> 
> [1]: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@oracle.com

Darren, you previously reported crashes with a patch very similar to 1/5.
Can you please test this patchset and report whether they
are still observed?
If yes, any data on how to reproduce would be very benefitial for Xuan
Zhuo.


> Xuan Zhuo (5):
>   virtio-net: fix overflow inside virtnet_rq_alloc
>   virtio_net: introduce vi->mode
>   virtio_net: big mode skip the unmap check
>   virtio_net: enable premapped mode for merge and small by default
>   virtio_net: rx remove premapped failover code
> 
>  drivers/net/virtio_net.c | 168 ++++++++++++++++++++++++---------------
>  1 file changed, 105 insertions(+), 63 deletions(-)
> 
> --
> 2.32.0.3.g01195cf9f


  parent reply	other threads:[~2024-10-14  4:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14  3:12 [PATCH 0/5] virtio_net: enable premapped mode by default Xuan Zhuo
2024-10-14  3:12 ` [PATCH 1/5] virtio-net: fix overflow inside virtnet_rq_alloc Xuan Zhuo
2024-10-17 13:42   ` Paolo Abeni
2024-10-19 16:34     ` Michael S. Tsirkin
2024-10-25  2:35     ` Xuan Zhuo
2024-10-25 13:22       ` Simon Horman
2024-10-18  7:41   ` Jason Wang
2024-10-25  2:40     ` Xuan Zhuo
2024-10-14  3:12 ` [PATCH 2/5] virtio_net: introduce vi->mode Xuan Zhuo
2024-10-18  7:48   ` Jason Wang
2024-10-25  2:47     ` Xuan Zhuo
2024-10-14  3:12 ` [PATCH 3/5] virtio_net: big mode skip the unmap check Xuan Zhuo
2024-10-14  3:12 ` [PATCH 4/5] virtio_net: enable premapped mode for merge and small by default Xuan Zhuo
2024-10-18  8:00   ` Jason Wang
2024-10-25  2:53     ` Xuan Zhuo
2024-10-14  3:12 ` [PATCH 5/5] virtio_net: rx remove premapped failover code Xuan Zhuo
2024-10-18  8:01   ` Jason Wang
2024-10-14  4:57 ` Michael S. Tsirkin [this message]
2024-10-16  7:55   ` [PATCH 0/5] virtio_net: enable premapped mode by default Darren Kenny
2024-10-18 14:59     ` Darren Kenny
2024-10-19 16:32       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241014005529-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=si-wei.liu@oracle.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.