Re: [RFC PATCH 2/2] crypto: Add Mediatek EIP-93 crypto engine support

[kernel test robot <lkp@intel.com>]

Hi Christian,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on herbert-cryptodev-2.6/master]
[also build test ERROR on herbert-crypto-2.6/master robh/for-next linus/master v6.12-rc2 next-20241011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/crypto-Add-Mediatek-EIP-93-crypto-engine-support/20241010-011532
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/20241009171223.12695-2-ansuelsmth%40gmail.com
patch subject: [RFC PATCH 2/2] crypto: Add Mediatek EIP-93 crypto engine support
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20241014/202410140056.ODffSy4g-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241014/202410140056.ODffSy4g-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410140056.ODffSy4g-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/crypto/mtk-eip93/eip93-main.c:483:34: error: array type has incomplete element type 'struct of_device_id'
     483 | static const struct of_device_id mtk_crypto_of_match[] = {
         |                                  ^~~~~~~~~~~~~~~~~~~
>> drivers/crypto/mtk-eip93/eip93-main.c:492:19: error: initialization of 'void (*)(struct platform_device *)' from incompatible pointer type 'int (*)(struct platform_device *)' [-Werror=incompatible-pointer-types]
     492 |         .remove = mtk_crypto_remove,
         |                   ^~~~~~~~~~~~~~~~~
   drivers/crypto/mtk-eip93/eip93-main.c:492:19: note: (near initialization for 'mtk_crypto_driver.<anonymous>.remove')
   cc1: some warnings being treated as errors
--
   drivers/crypto/mtk-eip93/eip93-common.c: In function 'mtk_send_req':
>> drivers/crypto/mtk-eip93/eip93-common.c:637:1: warning: label 'send_err' defined but not used [-Wunused-label]
     637 | send_err:
         | ^~~~~~~~
--
   drivers/crypto/mtk-eip93/eip93-hash.c: In function 'mtk_send_hash_req':
>> drivers/crypto/mtk-eip93/eip93-hash.c:231:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     231 |         int ret;
         |             ^~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for MODVERSIONS
   Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y]
   Selected by [y]:
   - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=n] || GCC_PLUGINS [=y]) && MODULES [=y]
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [m]:
   - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m]


vim +483 drivers/crypto/mtk-eip93/eip93-main.c

   482	
 > 483	static const struct of_device_id mtk_crypto_of_match[] = {
   484		{ .compatible = "mediatek,mtk-eip93", },
   485		{ .compatible = "airoha,mtk-eip93", },
   486		{}
   487	};
   488	MODULE_DEVICE_TABLE(of, mtk_crypto_of_match);
   489	
   490	static struct platform_driver mtk_crypto_driver = {
   491		.probe = mtk_crypto_probe,
 > 492		.remove = mtk_crypto_remove,
   493		.driver = {
   494			.name = "mtk-eip93",
   495			.of_match_table = mtk_crypto_of_match,
   496		},
   497	};
   498	module_platform_driver(mtk_crypto_driver);
   499	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki