From: Christoph Hellwig <hch@lst.de>
To: bingbu.cao@intel.com
Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
hch@lst.de, andriy.shevchenko@linux.intel.com,
bingbu.cao@linux.intel.com
Subject: Re: [PATCH 5/5] media: ipu6: use PFN_UP() and sg_virt() for code simplicity
Date: Mon, 14 Oct 2024 07:54:01 +0200 [thread overview]
Message-ID: <20241014055401.GC20331@lst.de> (raw)
In-Reply-To: <20241014034732.3109440-5-bingbu.cao@intel.com>
On Mon, Oct 14, 2024 at 11:47:32AM +0800, bingbu.cao@intel.com wrote:
> +++ b/drivers/media/pci/intel/ipu6/ipu6-dma.c
> @@ -139,7 +139,7 @@ void ipu6_dma_sync_sg(struct ipu6_bus_device *sys, struct scatterlist *sglist,
> int i;
>
> for_each_sg(sglist, sg, nents, i)
> - clflush_cache_range(page_to_virt(sg_page(sg)), sg->length);
> + clflush_cache_range(sg_virt(sg), sg->length);
Not new in this code, but what guarantees that this driver never sees
highmem?
next prev parent reply other threads:[~2024-10-14 5:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 3:47 [PATCH 1/5] media: ipu6: not override the dma_ops of device in driver bingbu.cao
2024-10-14 3:47 ` [PATCH 2/5] media: ipu6: use the IPU6 DMA mapping APIs to do mapping bingbu.cao
2024-10-14 3:47 ` [PATCH 3/5] media: ipu6: remove architecture DMA ops dependency in Kconfig bingbu.cao
2024-10-14 3:47 ` [PATCH 4/5] Documentation: ipu6: remove the dma_ops part from the doc bingbu.cao
2024-10-14 3:47 ` [PATCH 5/5] media: ipu6: use PFN_UP() and sg_virt() for code simplicity bingbu.cao
2024-10-14 5:54 ` Christoph Hellwig [this message]
2024-10-14 10:31 ` Bingbu Cao
2024-10-15 4:59 ` Christoph Hellwig
2024-10-14 5:53 ` [PATCH 1/5] media: ipu6: not override the dma_ops of device in driver Christoph Hellwig
2024-10-14 5:59 ` Bingbu Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014055401.GC20331@lst.de \
--to=hch@lst.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.