From: Bjorn Helgaas <helgaas@kernel.org>
To: Mayank Rana <quic_mrana@quicinc.com>
Cc: kevin.xie@starfivetech.com, lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_krichai@quicinc.com,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v3] PCI: starfive: Enable PCIe controller's runtime PM before probing host bridge
Date: Mon, 14 Oct 2024 12:23:21 -0500 [thread overview]
Message-ID: <20241014172321.GA612738@bhelgaas> (raw)
In-Reply-To: <20241014162607.1247611-1-quic_mrana@quicinc.com>
On Mon, Oct 14, 2024 at 09:26:07AM -0700, Mayank Rana wrote:
> PCIe controller device (i.e. PCIe starfive device) is parent to PCIe host
> bridge device. To enable runtime PM of PCIe host bridge device (child
> device), it is must to enable parent device's runtime PM to avoid seeing
> the below warning from PM core:
>
> pcie-starfive 940000000.pcie: Enabling runtime PM for inactive device
> with active children
>
> Fix this issue by enabling starfive pcie controller device's runtime PM
> before calling pci_host_probe() in plda_pcie_host_init().
>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Mayank Rana <quic_mrana@quicinc.com>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
I want this in the same series as Krishna's patch to turn on runtime
PM of host bridges. That's how I know they need to be applied in
order. If they're not in the same series, they're likely to be
applied out of order.
next prev parent reply other threads:[~2024-10-14 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 16:26 [PATCH v3] PCI: starfive: Enable PCIe controller's runtime PM before probing host bridge Mayank Rana
2024-10-14 17:23 ` Bjorn Helgaas [this message]
2024-10-14 17:40 ` Mayank Rana
2024-10-14 17:48 ` Manivannan Sadhasivam
2024-10-14 18:08 ` Bjorn Helgaas
2024-10-15 4:39 ` Manivannan Sadhasivam
2024-10-16 20:24 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014172321.GA612738@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kevin.xie@starfivetech.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_mrana@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.