From: Florian Westphal <fw@strlen.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
fw@strlen.de
Subject: Re: [PATCH net-next 0/9] Netfilter updates for net-net
Date: Mon, 14 Oct 2024 23:09:25 +0200 [thread overview]
Message-ID: <20241014210925.GA7558@breakpoint.cc> (raw)
In-Reply-To: <20241014131026.18abcc6b@kernel.org>
Jakub Kicinski <kuba@kernel.org> wrote:
> > 5) Use kfree_rcu() instead of call_rcu() + kmem_cache_free(), from Julia Lawall.
>
> Hi! Are you seeing any failures in nft_audit? I haven't looked closely
> but it seems that this PR causes:
>
> <snip>
> # testing for cmd: nft reset quotas t1 ... OK
> # testing for cmd: nft reset quotas t2 ... OK
> # testing for cmd: nft reset quotas ... OK
> # testing for cmd: nft delete rule t1 c1 handle 4 ... OK
> # testing for cmd: nft delete rule t1 c1 handle 5; delete rule t1 c1 handle 6 ... OK
> # testing for cmd: nft flush chain t1 c2 ... OK
> # testing for cmd: nft flush table t2 ... OK
> # testing for cmd: nft delete chain t2 c2 ... OK
> # testing for cmd: nft delete element t1 s { 22 } ... OK
> # testing for cmd: nft delete element t1 s { 80, 443 } ... FAIL
> # -table=t1 family=2 entries=2 op=nft_unregister_setelem
> # +table=t1 family=2 entries=1 op=nft_unregister_setelem
> # testing for cmd: nft flush set t1 s2 ... FAIL
My fault, Pablo, please toss all of my patches.
I do not know when I will resend, so do not wait.
next prev parent reply other threads:[~2024-10-14 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 11:14 [PATCH net-next 0/9] Netfilter updates for net-net Pablo Neira Ayuso
2024-10-14 11:14 ` [PATCH net-next 1/9] netfilter: nf_tables: Fix percpu address space issues in nf_tables_api.c Pablo Neira Ayuso
2024-10-14 11:14 ` [PATCH net-next 2/9] netfilter: nf_tables: replace deprecated strncpy with strscpy_pad Pablo Neira Ayuso
2024-10-14 11:14 ` [PATCH net-next 3/9] netfilter: nf_tables: prefer nft_trans_elem_alloc helper Pablo Neira Ayuso
2024-10-14 11:14 ` [PATCH net-next 4/9] netfilter: nf_tables: add nft_trans_commit_list_add_elem helper Pablo Neira Ayuso
2024-10-14 11:14 ` [PATCH net-next 5/9] netfilter: nf_tables: prepare for multiple elements in nft_trans_elem structure Pablo Neira Ayuso
2024-10-14 11:14 ` [PATCH net-next 6/9] netfilter: nf_tables: switch trans_elem to real flex array Pablo Neira Ayuso
2024-10-14 11:14 ` [PATCH net-next 7/9] netfilter: nf_tables: allocate element update information dynamically Pablo Neira Ayuso
2024-10-14 11:14 ` [PATCH net-next 8/9] netfilter: Make legacy configs user selectable Pablo Neira Ayuso
2024-10-14 11:14 ` [PATCH net-next 9/9] netfilter: replace call_rcu by kfree_rcu for simple kmem_cache_free callback Pablo Neira Ayuso
2024-10-14 20:10 ` [PATCH net-next 0/9] Netfilter updates for net-net Jakub Kicinski
2024-10-14 21:09 ` Florian Westphal [this message]
2024-10-14 22:00 ` Pablo Neira Ayuso
2024-10-14 22:20 ` Florian Westphal
2024-10-14 22:25 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014210925.GA7558@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.